Page MenuHomePhabricator
Files F13988368

D14485.id.diff
No OneTemporary
Actions

D14485.id.diff
View Options

diff --git a/src/applications/differential/controller/DifferentialChangesetViewController.php b/src/applications/differential/controller/DifferentialChangesetViewController.php
--- a/src/applications/differential/controller/DifferentialChangesetViewController.php
+++ b/src/applications/differential/controller/DifferentialChangesetViewController.php
@@ -387,7 +387,6 @@
$inlines = array();
foreach ($messages as $message) {
$description = $message->getProperty('description');
- $description = '%%%'.$description.'%%%';
$inlines[] = id(clone $template)
->setSyntheticAuthor(pht('Lint: %s', $message->getName()))
diff --git a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
--- a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
+++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
@@ -227,9 +227,7 @@
$action_buttons = array();
if ($this->allowReply) {
-
if (!$is_synthetic) {
-
// NOTE: No product reason why you can't reply to these, but the reply
// mechanism currently sends the inline comment ID to the server, not
// file/line information, and synthetic comments don't have an inline
@@ -242,7 +240,6 @@
->addSigil('differential-inline-reply')
->setMustCapture(true);
}
-
}
}
@@ -267,11 +264,11 @@
$links[] = javelin_tag(
'a',
array(
- 'class' => 'inline-button-divider pml msl',
- 'meta' => array(
+ 'class' => 'inline-button-divider pml msl',
+ 'meta' => array(
'anchor' => $anchor_name,
),
- 'sigil' => 'differential-inline-preview-jump',
+ 'sigil' => 'differential-inline-preview-jump',
),
pht('Not Visible'));

File Metadata

Mime Type
text/plain
Expires
Tue, Oct 22, 2:54 PM (4 w, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6729806
Default Alt Text
D14485.id.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility