Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13985271
D13206.id31926.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D13206.id31926.diff
View Options
diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
--- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
+++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
@@ -176,6 +176,7 @@
}
public function addPHIDHeaders($name, array $phids) {
+ $phids = array_unique($phids);
foreach ($phids as $phid) {
$this->addHeader($name, '<'.$phid.'>');
}
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -1018,11 +1018,7 @@
PhabricatorLiskDAO $object,
array $xactions) {
- // Before sending mail or publishing feed stories, reload the object
- // subscribers to pick up changes caused by Herald (or by other side effects
- // in various transaction phases).
- $this->loadSubscribers($object);
- // Hook for other edges that may need (re-)loading
+ // Hook for edges or other properties that may need (re-)loading
$object = $this->willPublish($object, $xactions);
$mailed = array();
@@ -2424,7 +2420,8 @@
$has_support = false;
if ($object instanceof PhabricatorSubscribableInterface) {
- $phids[] = $this->subscribers;
+ $phid = $object->getPHID();
+ $phids[] = PhabricatorSubscribersQuery::loadSubscribersForPHID($phid);
$has_support = true;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Oct 21, 7:18 PM (4 w, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6732915
Default Alt Text
D13206.id31926.diff (1 KB)
Attached To
Mode
D13206: Apply Herald subscription effects immediately
Attached
Detach File
Event Timeline
Log In to Comment