Page MenuHomePhabricator

D7969.id18029.diff
No OneTemporary

D7969.id18029.diff

Index: resources/celerity/map.php
===================================================================
--- resources/celerity/map.php
+++ resources/celerity/map.php
@@ -10,7 +10,7 @@
'core.pkg.css' => 'a35f9047',
'core.pkg.js' => 'c907bd96',
'darkconsole.pkg.js' => 'ca8671ce',
- 'differential.pkg.css' => '827749c1',
+ 'differential.pkg.css' => '5a65a762',
'differential.pkg.js' => '322ea941',
'diffusion.pkg.css' => '3783278d',
'diffusion.pkg.js' => '7b51e80a',
@@ -56,7 +56,7 @@
'rsrc/css/application/countdown/timer.css' => '86b7b0a0',
'rsrc/css/application/diff/inline-comment-summary.css' => '14a91639',
'rsrc/css/application/differential/add-comment.css' => 'c478bcaa',
- 'rsrc/css/application/differential/changeset-view.css' => 'cb858fc0',
+ 'rsrc/css/application/differential/changeset-view.css' => '82431767',
'rsrc/css/application/differential/core.css' => '8135cb0c',
'rsrc/css/application/differential/local-commits-view.css' => '19649019',
'rsrc/css/application/differential/results-table.css' => '239924f9',
@@ -495,7 +495,7 @@
'conpherence-notification-css' => 'f9ba9914',
'conpherence-update-css' => '1099a660',
'conpherence-widget-pane-css' => '87b12e0c',
- 'differential-changeset-view-css' => 'cb858fc0',
+ 'differential-changeset-view-css' => '82431767',
'differential-core-view-css' => '8135cb0c',
'differential-inline-comment-editor' => 'f2441746',
'differential-local-commits-view-css' => '19649019',
Index: src/applications/differential/view/DifferentialInlineCommentEditView.php
===================================================================
--- src/applications/differential/view/DifferentialInlineCommentEditView.php
+++ src/applications/differential/view/DifferentialInlineCommentEditView.php
@@ -104,16 +104,6 @@
),
pht('Cancel'));
- $formatting = phutil_tag(
- 'a',
- array(
- 'href' => PhabricatorEnv::getDoclink(
- 'article/Remarkup_Reference.html'),
- 'tabindex' => '-1',
- 'target' => '_blank',
- ),
- pht('Formatting Reference'));
-
$title = phutil_tag(
'div',
array(
@@ -134,7 +124,6 @@
'class' => 'differential-inline-comment-edit-buttons',
),
array(
- $formatting,
$buttons,
phutil_tag('div', array('style' => 'clear: both'), ''),
));
Index: src/infrastructure/diff/PhabricatorInlineCommentController.php
===================================================================
--- src/infrastructure/diff/PhabricatorInlineCommentController.php
+++ src/infrastructure/diff/PhabricatorInlineCommentController.php
@@ -235,14 +235,11 @@
}
private function renderTextArea($text) {
- return javelin_tag(
- 'textarea',
- array(
- 'class' => 'differential-inline-comment-edit-textarea',
- 'sigil' => 'differential-inline-comment-edit-textarea',
- 'name' => 'text',
- ),
- $text);
+ return id(new PhabricatorRemarkupControl())
+ ->setUser($this->getRequest()->getUser())
+ ->setSigil('differential-inline-comment-edit-textarea')
+ ->setName('text')
+ ->setValue($text);
}
}
Index: webroot/rsrc/css/application/differential/changeset-view.css
===================================================================
--- webroot/rsrc/css/application/differential/changeset-view.css
+++ webroot/rsrc/css/application/differential/changeset-view.css
@@ -287,10 +287,9 @@
font-style: normal;
}
-
-.differential-inline-comment-edit-textarea {
+.differential-inline-comment-edit-body .aphront-form-input {
+ margin: 0;
width: 100%;
- height: 12em;
}
.differential-changeset-buttons {

File Metadata

Mime Type
text/plain
Expires
Mon, Oct 21, 11:41 AM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6739215
Default Alt Text
D7969.id18029.diff (3 KB)

Event Timeline