Page MenuHomePhabricator

Use RemarkupControl in Differential inline comment UI
ClosedPublic

Authored by epriestley on Jan 14 2014, 10:51 PM.
Tags
None
Referenced Files
F15454091: D7969.id18028.diff
Sat, Mar 29, 4:15 PM
F15449390: D7969.id18029.diff
Fri, Mar 28, 9:54 AM
F15448626: D7969.id18031.diff
Fri, Mar 28, 5:59 AM
F15443494: D7969.id.diff
Thu, Mar 27, 4:42 AM
F15440670: D7969.diff
Wed, Mar 26, 2:02 PM
F15420311: D7969.id18031.diff
Fri, Mar 21, 12:59 PM
F15415273: D7969.id18028.diff
Thu, Mar 20, 5:09 AM
F15413233: D7969.id.diff
Wed, Mar 19, 5:34 PM
Subscribers

Details

Summary

Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan

{F101825}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 10:52 PM
  • Also setUser() to actually pick up monospacing.

i will do what I can to make facebook hate this