Page MenuHomePhabricator

Use RemarkupControl in Differential inline comment UI
ClosedPublic

Authored by epriestley on Jan 14 2014, 10:51 PM.
Tags
None
Referenced Files
F19689338: D7969.id18028.diff
Mon, Feb 9, 9:05 PM
F19674455: D7969.diff
Sun, Feb 8, 7:43 AM
F19601710: D7969.id18028.diff
Tue, Feb 3, 5:21 AM
F19561654: D7969.id18029.diff
Sat, Jan 31, 10:50 AM
F19543269: D7969.id18028.diff
Thu, Jan 22, 5:48 PM
F19534133: D7969.id18031.diff
Tue, Jan 20, 10:37 PM
F19507031: D7969.id18028.diff
Jan 9 2026, 5:11 PM
F19506353: D7969.id18031.diff
Jan 9 2026, 4:45 PM
Subscribers

Details

Summary

Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan

{F101825}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 10:52 PM
  • Also setUser() to actually pick up monospacing.

i will do what I can to make facebook hate this