Page MenuHomePhabricator

Use RemarkupControl in Differential inline comment UI
ClosedPublic

Authored by epriestley on Jan 14 2014, 10:51 PM.
Tags
None
Referenced Files
F18827580: D7969.id18031.diff
Fri, Oct 24, 10:55 AM
F18783499: D7969.diff
Mon, Oct 13, 7:15 AM
F18630696: D7969.id.diff
Sep 16 2025, 12:40 PM
F18599690: D7969.id18029.diff
Sep 13 2025, 8:00 AM
F18536246: D7969.diff
Sep 7 2025, 1:44 PM
F17949466: D7969.id18031.diff
Jul 31 2025, 11:29 PM
F17728797: D7969.id18029.diff
Jul 19 2025, 5:04 PM
Unknown Object (File)
Jun 18 2025, 6:00 PM
Subscribers

Details

Summary

Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan

{F101825}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 10:52 PM
  • Also setUser() to actually pick up monospacing.

i will do what I can to make facebook hate this