Page MenuHomePhabricator

Use RemarkupControl in Differential inline comment UI
ClosedPublic

Authored by epriestley on Jan 14 2014, 10:51 PM.
Tags
None
Referenced Files
F17949466: D7969.id18031.diff
Jul 31 2025, 11:29 PM
F17728797: D7969.id18029.diff
Jul 19 2025, 5:04 PM
Unknown Object (File)
Jun 18 2025, 6:00 PM
Unknown Object (File)
Jun 18 2025, 2:02 PM
Unknown Object (File)
Jun 18 2025, 12:06 PM
Unknown Object (File)
Jun 17 2025, 4:18 AM
Unknown Object (File)
Jun 16 2025, 10:35 PM
Unknown Object (File)
Jun 16 2025, 2:35 PM
Subscribers

Details

Summary

Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan

{F101825}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 10:52 PM
  • Also setUser() to actually pick up monospacing.

i will do what I can to make facebook hate this