Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13980094
D14485.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D14485.id.diff
View Options
diff --git a/src/applications/differential/controller/DifferentialChangesetViewController.php b/src/applications/differential/controller/DifferentialChangesetViewController.php
--- a/src/applications/differential/controller/DifferentialChangesetViewController.php
+++ b/src/applications/differential/controller/DifferentialChangesetViewController.php
@@ -387,7 +387,6 @@
$inlines = array();
foreach ($messages as $message) {
$description = $message->getProperty('description');
- $description = '%%%'.$description.'%%%';
$inlines[] = id(clone $template)
->setSyntheticAuthor(pht('Lint: %s', $message->getName()))
diff --git a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
--- a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
+++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
@@ -227,9 +227,7 @@
$action_buttons = array();
if ($this->allowReply) {
-
if (!$is_synthetic) {
-
// NOTE: No product reason why you can't reply to these, but the reply
// mechanism currently sends the inline comment ID to the server, not
// file/line information, and synthetic comments don't have an inline
@@ -242,7 +240,6 @@
->addSigil('differential-inline-reply')
->setMustCapture(true);
}
-
}
}
@@ -267,11 +264,11 @@
$links[] = javelin_tag(
'a',
array(
- 'class' => 'inline-button-divider pml msl',
- 'meta' => array(
+ 'class' => 'inline-button-divider pml msl',
+ 'meta' => array(
'anchor' => $anchor_name,
),
- 'sigil' => 'differential-inline-preview-jump',
+ 'sigil' => 'differential-inline-preview-jump',
),
pht('Not Visible'));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Oct 20 2024, 8:27 AM (4 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6729806
Default Alt Text
D14485.id.diff (1 KB)
Attached To
Mode
D14485: Allow lint messages to be rendered as Remarkup
Attached
Detach File
Event Timeline
Log In to Comment