Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13979727
D16180.id.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
751 B
Referenced Files
None
Subscribers
None
D16180.id.diff
View Options
diff --git a/src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.php b/src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.php
--- a/src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.php
+++ b/src/applications/diffusion/herald/DiffusionPreCommitContentRevisionAcceptedHeraldField.php
@@ -21,7 +21,9 @@
}
$status_accepted = ArcanistDifferentialRevisionStatus::ACCEPTED;
- if ($revision->getStatus() != $status_accepted) {
+ $status_closed = ArcanistDifferentialRevisionStatus::CLOSED;
+ if (($revision->getStatus() != $status_accepted) &&
+ ($revision->getStatus() != $status_closed)) {
return null;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Oct 20, 6:06 AM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6712304
Default Alt Text
D16180.id.diff (751 B)
Attached To
Mode
D16180: Status Closed should also concieved as Accepted
Attached
Detach File
Event Timeline
Log In to Comment