Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13976198
D10201.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D10201.diff
View Options
diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -671,9 +671,9 @@
$open_status_list[] = json_encode((string)$constant);
}
- $tasks = queryfx_all(
+ $rows = queryfx_all(
$conn_r,
- 'SELECT t.* FROM %T t JOIN %T x ON x.objectPHID = t.phid
+ 'SELECT t.id FROM %T t JOIN %T x ON x.objectPHID = t.phid
WHERE t.status NOT IN (%Ls)
AND x.oldValue IN (null, %Ls)
AND x.newValue NOT IN (%Ls)
@@ -687,7 +687,16 @@
$window_epoch,
$window_epoch);
- return id(new ManiphestTask())->loadAllFromArray($tasks);
+ if (!$rows) {
+ return array();
+ }
+
+ $ids = ipull($rows, 'id');
+
+ return id(new ManiphestTaskQuery())
+ ->setViewer($this->getRequest()->getUser())
+ ->withIDs($ids)
+ ->execute();
}
/**
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Oct 19 2024, 1:15 PM (4 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6715936
Default Alt Text
D10201.diff (1 KB)
Attached To
Mode
D10201: Use ManiphestTaskQuery instead of ad-hoc load in Maniphest reports
Attached
Detach File
Event Timeline
Log In to Comment