Use ManiphestTaskQuery instead of ad-hoc load in Maniphest reports
ClosedPublic
Actions

Authored by epriestley on Aug 8 2014, 11:06 PM.

Tags

None

Referenced Files

	F15534575: D10201.id24547.diff
	Thu, Apr 24, 12:53 AM

	F15491971: D10201.id24545.diff
	Sat, Apr 12, 9:27 AM

	F15485967: D10201.id24547.diff
	Thu, Apr 10, 3:59 AM

	F15478221: D10201.id24545.diff
	Mon, Apr 7, 9:14 PM

	F15474143: D10201.id.diff
	Sun, Apr 6, 5:38 AM

	F15472212: D10201.id24547.diff
	Sat, Apr 5, 11:22 AM

	F15471298: D10201.diff
	Sat, Apr 5, 4:24 AM

	F15461897: D10201.id.diff
	Tue, Apr 1, 12:13 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T5829: PhabricatorDataNotAttachedException thrown at /maniphest/report/project/

Commits

Restricted Diffusion Commit
rP664507e45096: Use ManiphestTaskQuery instead of ad-hoc load in Maniphest reports

Summary

Fixes T5829. This stuff is old and busted, but keep it working for now.

Test Plan

No more fatal when there are recently closed tasks.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24545.Aug 8 2014, 11:06 PM

epriestley retitled this revision from to Use ManiphestTaskQuery instead of ad-hoc load in Maniphest reports.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5829: PhabricatorDataNotAttachedException thrown at /maniphest/report/project/.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 8 2014, 11:06 PM

Harbormaster completed remote builds in B2122: Diff 24545.Aug 8 2014, 11:07 PM

btrahan accepted this revision.Aug 8 2014, 11:18 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 8 2014, 11:18 PM

Closed by commit rP664507e45096 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestReportController.php

15 lines

Diff 24547

View Options

src/applications/maniphest/controller/ManiphestReportController.php

Use ManiphestTaskQuery instead of ad-hoc load in Maniphest reportsClosedPublicActions