Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13975793
D18332.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
3 KB
Referenced Files
None
Subscribers
None
D18332.diff
View Options
diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => 'b5b51108',
- 'core.pkg.css' => 'd9c9cfd0',
+ 'core.pkg.css' => '851ae625',
'core.pkg.js' => '5d80e0db',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '45951e9e',
@@ -42,7 +42,7 @@
'rsrc/css/application/base/main-menu-view.css' => '16053029',
'rsrc/css/application/base/notification-menu.css' => '73fefdfa',
'rsrc/css/application/base/phui-theme.css' => '9f261c6b',
- 'rsrc/css/application/base/standard-page-view.css' => 'eb5b80c5',
+ 'rsrc/css/application/base/standard-page-view.css' => 'a0dae682',
'rsrc/css/application/chatlog/chatlog.css' => 'd295b020',
'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
'rsrc/css/application/config/config-options.css' => 'd55ed093',
@@ -802,7 +802,7 @@
'phabricator-shaped-request' => '7cbe244b',
'phabricator-slowvote-css' => 'a94b7230',
'phabricator-source-code-view-css' => 'aea41829',
- 'phabricator-standard-page-view' => 'eb5b80c5',
+ 'phabricator-standard-page-view' => 'a0dae682',
'phabricator-textareautils' => '320810c8',
'phabricator-title' => '485aaa6c',
'phabricator-tooltip' => '358b8c04',
diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php
--- a/src/view/page/PhabricatorStandardPageView.php
+++ b/src/view/page/PhabricatorStandardPageView.php
@@ -19,6 +19,7 @@
private $showFooter = true;
private $showDurableColumn = true;
private $quicksandConfig = array();
+ private $tabs;
private $crumbs;
private $navigation;
@@ -159,6 +160,17 @@
return $this->crumbs;
}
+ public function setTabs(PHUIListView $tabs) {
+ $tabs->setType(PHUIListView::TABBAR_LIST);
+ $tabs->addClass('phabricator-standard-page-tabs');
+ $this->tabs = $tabs;
+ return $this;
+ }
+
+ public function getTabs() {
+ return $this->tabs;
+ }
+
public function setNavigation(AphrontSideNavFilterView $navigation) {
$this->navigation = $navigation;
return $this;
@@ -528,6 +540,7 @@
$footer = $this->renderFooter();
$nav = $this->getNavigation();
+ $tabs = $this->getTabs();
if ($nav) {
$crumbs = $this->getCrumbs();
if ($crumbs) {
@@ -541,9 +554,17 @@
$crumbs = $this->getCrumbs();
if ($crumbs) {
+ if ($this->getTabs()) {
+ $crumbs->setBorder(true);
+ }
$content[] = $crumbs;
}
+ $tabs = $this->getTabs();
+ if ($tabs) {
+ $content[] = $tabs;
+ }
+
$content[] = $body;
$content[] = $footer;
diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css
--- a/webroot/rsrc/css/application/base/standard-page-view.css
+++ b/webroot/rsrc/css/application/base/standard-page-view.css
@@ -176,3 +176,14 @@
position: absolute;
left: -50px;
}
+
+.phabricator-standard-page-tabs {
+ padding: 0 32px;
+ margin-bottom: 32px;
+ background: {$page.content};
+ box-shadow: 0 0 3px 0 rgba(0,0,0,0.2);
+}
+
+.phabricator-standard-page-tabs.phui-list-tabbar .phui-list-item-href {
+ padding: 12px 24px;
+}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Oct 19, 11:40 AM (4 w, 22 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6727944
Default Alt Text
D18332.diff (3 KB)
Attached To
Mode
D18332: Allow setting of tabs at StandardPageView
Attached
Detach File
Event Timeline
Log In to Comment