Paths

Table of Contentst

Differential D18332

Allow setting of tabs at StandardPageView
ClosedPublic
Actions

Authored by chad on Aug 3 2017, 11:52 PM.

Details

Reviewers

epriestley

Commits

rPfedf08743ffd: Allow setting of tabs at StandardPageView

Summary

Rather than have tabs live in two column view, sometimes like admin we'll want a global set of tabs that work well with all layouts and crumbs.

Test Plan

I tested this in an upcoming diff for instances.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 3 2017, 11:52 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 3 2017, 11:52 PM

Harbormaster completed remote builds in B17897: Diff 44078.Aug 3 2017, 11:53 PM

btw im assuming we're merging 'pacts' and 'support' to just 'support' once dust clears.

epriestley accepted this revision.Aug 4 2017, 1:28 AM

This revision is now accepted and ready to land.Aug 4 2017, 1:28 AM

Closed by commit rPfedf08743ffd: Allow setting of tabs at StandardPageView (authored by chad, committed by chad). · Explain WhyAug 4 2017, 2:01 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

src/

view/

page/

PhabricatorStandardPageView.php

21 lines

webroot/

rsrc/

css/

application/

base/

standard-page-view.css

11 lines

Diff 44083

View Options

resources/celerity/map.php

View Options

src/view/page/PhabricatorStandardPageView.php

View Options

webroot/rsrc/css/application/base/standard-page-view.css

Allow setting of tabs at StandardPageViewClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44083

resources/celerity/map.php

src/view/page/PhabricatorStandardPageView.php

webroot/rsrc/css/application/base/standard-page-view.css

Allow setting of tabs at StandardPageView
ClosedPublic
Actions

Revision Contents
Changeset List