D18886.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D18886.diff
View Options

	diff --git a/src/applications/differential/storage/DifferentialTransaction.php b/src/applications/differential/storage/DifferentialTransaction.php
	--- a/src/applications/differential/storage/DifferentialTransaction.php
	+++ b/src/applications/differential/storage/DifferentialTransaction.php
	@@ -100,6 +100,13 @@
	return true;
	}
	break;
	+ case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
	+ // Don't hide the initial "X requested review: ..." transaction from
	+ // mail or feed even when it occurs during creation. We need this
	+ // transaction to survive so we'll generate mail and feed stories when
	+ // revisions immediately leave the draft state. See T13035 for
	+ // discussion.
	+ return false;
	}

	return parent::shouldHide();
	@@ -111,12 +118,6 @@
	// Don't hide the initial "X added reviewers: ..." transaction during
	// object creation from mail. See T12118 and PHI54.
	return false;
	- case DifferentialRevisionRequestReviewTransaction::TRANSACTIONTYPE:
	- // Don't hide the initial "X requested review: ..." transaction from
	- // mail even when it occurs during creation. We need this transaction
	- // to survive so we'll generate mail when revisions immediately leave
	- // the draft state. See T13035 for discussion.
	- return false;
	}

	return parent::shouldHideForMail($xactions);