Page MenuHomePhabricator
Files F13973847

D12650.diff
No OneTemporary
Actions

D12650.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -11,7 +11,7 @@
'core.pkg.js' => '59d01bb7',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '3500921f',
- 'differential.pkg.js' => '890046d3',
+ 'differential.pkg.js' => 'bffbb5bf',
'diffusion.pkg.css' => '591664fa',
'diffusion.pkg.js' => '0115b37c',
'maniphest.pkg.css' => '68d4dd3d',
@@ -58,7 +58,7 @@
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
'rsrc/css/application/differential/changeset-view.css' => 'e19cfd6e',
'rsrc/css/application/differential/core.css' => '7ac3cabc',
- 'rsrc/css/application/differential/phui-inline-comment.css' => 'ebe46529',
+ 'rsrc/css/application/differential/phui-inline-comment.css' => '1cf3cbe4',
'rsrc/css/application/differential/results-table.css' => '181aa9d9',
'rsrc/css/application/differential/revision-comment.css' => '024dda6b',
'rsrc/css/application/differential/revision-history.css' => '0e8eb855',
@@ -374,7 +374,7 @@
'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1',
'rsrc/js/application/differential/behavior-dropdown-menus.js' => '2035b9cb',
'rsrc/js/application/differential/behavior-edit-inline-comments.js' => 'e723c323',
- 'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492',
+ 'rsrc/js/application/differential/behavior-keyboard-nav.js' => '6c4943ca',
'rsrc/js/application/differential/behavior-populate.js' => '8694b1df',
'rsrc/js/application/differential/behavior-show-field-details.js' => 'bba9eedf',
'rsrc/js/application/differential/behavior-toggle-files.js' => 'ca3f91eb',
@@ -577,7 +577,7 @@
'javelin-behavior-differential-dropdown-menus' => '2035b9cb',
'javelin-behavior-differential-edit-inline-comments' => 'e723c323',
'javelin-behavior-differential-feedback-preview' => '8e1389b5',
- 'javelin-behavior-differential-keyboard-navigation' => '2c426492',
+ 'javelin-behavior-differential-keyboard-navigation' => '6c4943ca',
'javelin-behavior-differential-populate' => '8694b1df',
'javelin-behavior-differential-show-field-details' => 'bba9eedf',
'javelin-behavior-differential-toggle-files' => 'ca3f91eb',
@@ -795,7 +795,7 @@
'phui-image-mask-css' => '5a8b09c8',
'phui-info-panel-css' => '27ea50a1',
'phui-info-view-css' => 'c6f0aef8',
- 'phui-inline-comment-view-css' => 'ebe46529',
+ 'phui-inline-comment-view-css' => '1cf3cbe4',
'phui-list-view-css' => '2e25ebfb',
'phui-object-box-css' => '7d160002',
'phui-object-item-list-view-css' => '9db65899',
@@ -1026,12 +1026,6 @@
'javelin-stratcom',
'javelin-dom',
),
- '2c426492' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-stratcom',
- 'phabricator-keyboard-shortcut',
- ),
'2caa8fb8' => array(
'javelin-install',
'javelin-event',
@@ -1319,6 +1313,12 @@
'javelin-install',
'javelin-util',
),
+ '6c4943ca' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-stratcom',
+ 'phabricator-keyboard-shortcut',
+ ),
'6c53634d' => array(
'javelin-install',
'javelin-event',
diff --git a/webroot/rsrc/css/application/differential/phui-inline-comment.css b/webroot/rsrc/css/application/differential/phui-inline-comment.css
--- a/webroot/rsrc/css/application/differential/phui-inline-comment.css
+++ b/webroot/rsrc/css/application/differential/phui-inline-comment.css
@@ -47,7 +47,7 @@
font-weight: bold;
color: {$darkbluetext};
border-bottom: 1px solid {$sh-lightyellowborder};
- padding: 4px 5px 2px 12px;
+ padding: 4px 5px 3px 12px;
background-color: {$sh-yellowbackground};
}
@@ -138,11 +138,6 @@
*/
-.differential-inline-comment.inline-comment-ghost {
- border: 1px solid {$lightgreyborder};
- opacity: 0.75;
-}
-
.differential-inline-comment.inline-comment-ghost
.differential-inline-comment-head {
border-bottom: 1px solid {$lightgreyborder};
@@ -278,7 +273,7 @@
border: 1px solid {$sh-yellowborder};
border-radius: 3px;
display: inline-block;
- padding: 3px 8px 4px;
+ padding: 4px 8px 5px;
cursor: pointer;
}
@@ -415,7 +410,7 @@
}
.ghost-icon .phui-icon-view {
- padding: 7px;
+ padding: 8px 7px 7px;
font-size: 15px;
color: {$lightbluetext};
}
@@ -428,6 +423,7 @@
display: none;
}
+.show-ghost-ui .inline-comment-ghost .differential-inline-comment-content,
.inline-comment-ghost.ghost-is-expanded .differential-inline-comment-content {
display: block;
}
@@ -438,6 +434,8 @@
position: relative;
}
+.show-ghost-ui .differential-inline-comment.inline-comment-ghost
+ .differential-inline-comment-head,
.differential-inline-comment.inline-comment-ghost.ghost-is-expanded
.differential-inline-comment-head {
border-bottom-color: {$thinblueborder};
diff --git a/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js b/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js
--- a/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js
+++ b/webroot/rsrc/js/application/differential/behavior-keyboard-nav.js
@@ -183,6 +183,22 @@
}
}
+ var ghost_toggle = 0;
+ function ghostui() {
+ var el = JX.$('differential-review-stage');
+ if (ghost_toggle == 0) {
+ JX.DOM.alterClass(el, 'show-ghost-ui', true);
+ ghost_toggle = 1;
+ } else {
+ JX.DOM.alterClass(el, 'show-ghost-ui', false);
+ ghost_toggle = 0;
+ }
+ }
+
+ new JX.KeyboardShortcut('f', 'Show all inline comments.')
+ .setHandler(ghostui)
+ .register();
+
new JX.KeyboardShortcut('j', 'Jump to next change.')
.setHandler(function(manager) {
jump(manager, 1);

File Metadata

Mime Type
text/plain
Expires
Sat, Oct 19, 2:59 AM (21 h, 42 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6729971
Default Alt Text
D12650.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility