Page MenuHomePhabricator

[Draft] Toggle inline comments on/off
AbandonedPublic

Authored by chad on May 2 2015, 1:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 10:58 PM
Unknown Object (File)
Feb 3 2024, 6:28 PM
Unknown Object (File)
Feb 3 2024, 5:57 PM
Unknown Object (File)
Feb 3 2024, 3:35 AM
Unknown Object (File)
Jan 30 2024, 8:22 PM
Unknown Object (File)
Jan 30 2024, 5:05 PM
Unknown Object (File)
Dec 26 2023, 8:35 PM
Unknown Object (File)
Dec 26 2023, 2:29 AM
Subscribers

Details

Reviewers
epriestley
Summary

Just for testing. Press f to turn on all inline comments.

Test Plan

toggle lots

Diff Detail

Repository
rP Phabricator
Branch
ghost-js-shortcut
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/differential/behavior-keyboard-nav.js:189W041JSHintW041
Unit
No Test Coverage
Build Status
Buildable 5666
Build 5685: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to [Draft] Toggle inline comments on/off.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

I can't say this "feels right" either, but I wanted to at least test / play with a keyboard toggle.

My last idea would be to collapse threads, so entire conversations collapse to 1 line, and expand fully with 1-click. But not sure I can fake that with CSS.