Page MenuHomePhabricator
Differential D12650

[Draft] Toggle inline comments on/off
AbandonedPublic
Actions

Authored by chad on May 2 2015, 1:44 AM.
Tags
None
Referenced Files
F14040047: D12650.id.diff
Mon, Nov 11, 7:12 AM
F14013587: D12650.id.diff
Sat, Nov 2, 7:53 AM
F13999074: D12650.id.diff
Thu, Oct 24, 12:46 PM
F13976245: D12650.diff
Fri, Oct 18, 1:24 PM
F13973847: D12650.diff
Oct 18 2024, 2:59 AM
Unknown Object (File)
Oct 8 2024, 5:46 PM
Unknown Object (File)
Oct 8 2024, 5:46 PM
Unknown Object (File)
Oct 8 2024, 5:27 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Summary

Just for testing. Press f to turn on all inline comments.

Test Plan

toggle lots

Diff Detail

Repository
rP Phabricator
Branch
ghost-js-shortcut
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/differential/behavior-keyboard-nav.js:189W041JSHintW041
Unit
No Test Coverage
Build Status
Buildable 5666
Build 5685: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30390.May 2 2015, 1:44 AM
chad retitled this revision from to [Draft] Toggle inline comments on/off.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 2 2015, 1:44 AM
chad added a comment.May 2 2015, 2:01 AM

I can't say this "feels right" either, but I wanted to at least test / play with a keyboard toggle.

My last idea would be to collapse threads, so entire conversations collapse to 1 line, and expand fully with 1-click. But not sure I can fake that with CSS.

chad abandoned this revision.May 4 2015, 6:20 PM
shrinidhirao mentioned this in T7447: Bring inline comments forward across revision updates.May 15 2015, 3:06 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
22 lines
webroot/
rsrc/
css/
application/
differential/
14 lines
js/
application/
differential/
16 lines

Diff 30390

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

Loading...
Phabricator · Built by Phacility