D9196.diff
No OneTemporary
Actions

Size

966 B

Referenced Files

None

Subscribers

None

D9196.diff
View Options

	diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
	--- a/src/lint/linter/ArcanistXHPASTLinter.php
	+++ b/src/lint/linter/ArcanistXHPASTLinter.php
	@@ -2428,7 +2428,7 @@
	$valid = true;
	} else if (!$contains_special_chars && !$single_quoted) {
	$invalid_nodes[] = $string;
	- $fixes[$string->getID()] = "'".$contents."'";
	+ $fixes[$string->getID()] = "'".str_replace('\"', '"', $contents)."'";
	}
	}

	diff --git a/src/lint/linter/__tests__/xhpast/double-quote.lint-test b/src/lint/linter/__tests__/xhpast/double-quote.lint-test
	--- a/src/lint/linter/__tests__/xhpast/double-quote.lint-test
	+++ b/src/lint/linter/__tests__/xhpast/double-quote.lint-test
	@@ -1,6 +1,6 @@
	<?php
	'foobar';
	-"foobar";
	+"foo\"bar";
	"foobar\n";
	"'foobar'";
	"foo{$bar}";
	@@ -16,7 +16,7 @@
	~~~~~~~~~~
	<?php
	'foobar';
	-'foobar';
	+'foo"bar';
	"foobar\n";
	"'foobar'";
	"foo{$bar}";