Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13969513
D14246.id34396.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D14246.id34396.diff
View Options
diff --git a/src/lint/linter/ArcanistExternalLinter.php b/src/lint/linter/ArcanistExternalLinter.php
--- a/src/lint/linter/ArcanistExternalLinter.php
+++ b/src/lint/linter/ArcanistExternalLinter.php
@@ -277,9 +277,9 @@
$binary = $this->getBinary();
if ($interpreter) {
- $bin = csprintf('%s %s', $interpreter, $binary);
+ $bin = csprintf('%C %s', $interpreter, $binary);
} else {
- $bin = csprintf('%s', $binary);
+ $bin = csprintf('%C', $binary);
}
return $bin;
diff --git a/src/lint/linter/ArcanistPuppetLintLinter.php b/src/lint/linter/ArcanistPuppetLintLinter.php
--- a/src/lint/linter/ArcanistPuppetLintLinter.php
+++ b/src/lint/linter/ArcanistPuppetLintLinter.php
@@ -38,7 +38,7 @@
list($stdout) = execx('%C --version', $this->getExecutableCommand());
$matches = array();
- $regex = '/^puppet-lint (?P<version>\d+\.\d+\.\d+)$/';
+ $regex = '/^puppet-lint (?P<version>\d+\.\d+\.\d+)\s*$/';
if (preg_match($regex, $stdout, $matches)) {
return $matches['version'];
} else {
diff --git a/src/lint/linter/ArcanistRuboCopLinter.php b/src/lint/linter/ArcanistRuboCopLinter.php
--- a/src/lint/linter/ArcanistRuboCopLinter.php
+++ b/src/lint/linter/ArcanistRuboCopLinter.php
@@ -34,7 +34,7 @@
list($stdout) = execx('%C --version', $this->getExecutableCommand());
$matches = array();
- if (preg_match('/^(?P<version>\d+\.\d+\.\d+)$/', $stdout, $matches)) {
+ if (preg_match('/^(?P<version>\d+\.\d+\.\d+)\s*$/', $stdout, $matches)) {
return $matches['version'];
} else {
return false;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Oct 18, 2:56 AM (3 w, 6 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6724613
Default Alt Text
D14246.id34396.diff (1 KB)
Attached To
Mode
D14246: Do not escape binary paths in external linters
Attached
Detach File
Event Timeline
Log In to Comment