Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13965395
D15457.id37251.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D15457.id37251.diff
View Options
diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -481,19 +481,21 @@
->setBaseURI(new PhutilURI('/D'.$revision->getID()))
->setCollapsed((bool)$collapsed)
->build($changesets);
- $nav->appendChild($content);
- $nav->setCrumbs($crumbs);
- $content = $nav;
} else {
- array_unshift($content, $crumbs);
+ $nav = null;
}
- return $this->buildApplicationPage(
- $content,
- array(
- 'title' => $object_id.' '.$revision->getTitle(),
- 'pageObjects' => array($revision->getPHID()),
- ));
+ $page = $this->newPage()
+ ->setTitle($object_id.' '.$revision->getTitle())
+ ->setCrumbs($crumbs)
+ ->setPageObjectPHIDs(array($revision->getPHID()))
+ ->appendChild($content);
+
+ if ($nav) {
+ $page->setNavigation($nav);
+ }
+
+ return $page;
}
private function getRevisionActions(DifferentialRevision $revision) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Oct 17 2024, 1:46 AM (4 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6720093
Default Alt Text
D15457.id37251.diff (1 KB)
Attached To
Mode
D15457: Move DifferentialRevisionViewController to newPage()
Attached
Detach File
Event Timeline
Log In to Comment