Page MenuHomePhabricator
Differential D15457

Move DifferentialRevisionViewController to newPage()
ClosedPublic
Actions

Authored by epriestley on Mar 10 2016, 9:20 PM.
Tags
None
Referenced Files
F15423522: D15457.id.diff
Sat, Mar 22, 3:48 PM
F15400383: D15457.diff
Mon, Mar 17, 11:21 AM
F15340912: D15457.diff
Sun, Mar 9, 5:37 PM
F15329914: D15457.id37251.diff
Mar 7 2025, 7:09 AM
F15283853: D15457.diff
Mar 4 2025, 8:46 AM
Unknown Object (File)
Feb 5 2025, 9:06 AM
Unknown Object (File)
Jan 24 2025, 1:08 AM
Unknown Object (File)
Jan 21 2025, 9:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP7b8da9991429: Move DifferentialRevisionViewController to newPage()
Summary

I think this works?

Test Plan

i am wizard

Screen Shot 2016-03-10 at 1.19.22 PM.png (1×3 px, 389 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37251.Mar 10 2016, 9:20 PM
epriestley retitled this revision from to Move DifferentialRevisionViewController to newPage().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald edited edge metadata. · View Herald TranscriptMar 10 2016, 9:20 PM
chad added a comment.Mar 10 2016, 9:21 PM

haha, there already was a setNavigation lulz.

epriestley added a comment.Mar 10 2016, 9:21 PM

i am time wizard

chad accepted this revision.Mar 10 2016, 9:22 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2016, 9:22 PM
Closed by commit rP7b8da9991429: Move DifferentialRevisionViewController to newPage() (authored by epriestley, committed by epriestley). · Explain WhyMar 10 2016, 9:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
22 lines

Diff 37252

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
Phabricator · Built by Phacility