Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13957545
D20902.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D20902.diff
View Options
diff --git a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
--- a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
+++ b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
@@ -329,9 +329,16 @@
$actions = array();
if ($panel) {
- $panel_actions = $panel->newHeaderEditActions(
- $viewer,
- $context_phid);
+ try {
+ $panel_actions = $panel->newHeaderEditActions(
+ $viewer,
+ $context_phid);
+ } catch (Exception $ex) {
+ $error_action = id(new PhabricatorActionView())
+ ->setIcon('fa-exclamation-triangle red')
+ ->setName(pht('<Rendering Exception>'));
+ $panel_actions[] = $error_action;
+ }
if ($panel_actions) {
foreach ($panel_actions as $panel_action) {
diff --git a/src/applications/differential/query/DifferentialChangesetSearchEngine.php b/src/applications/differential/query/DifferentialChangesetSearchEngine.php
--- a/src/applications/differential/query/DifferentialChangesetSearchEngine.php
+++ b/src/applications/differential/query/DifferentialChangesetSearchEngine.php
@@ -22,6 +22,10 @@
return 'PhabricatorDifferentialApplication';
}
+ public function canUseInPanelContext() {
+ return false;
+ }
+
public function newQuery() {
$query = id(new DifferentialChangesetQuery());
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Oct 15, 9:52 AM (2 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6712441
Default Alt Text
D20902.diff (1 KB)
Attached To
Mode
D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation
Attached
Detach File
Event Timeline
Log In to Comment