Page MenuHomePhabricator

Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation
ClosedPublic

Authored by epriestley on Sat, Nov 9, 1:12 AM.

Details

Summary

Fixes T13443. When a panel raises an exception during edit action generation, it currently escapes to top level. Instead, catch it more narrowly.

Additionally, mark "ChangesetSearchEngine" as not being a suitable search engine for use in query panels. There's no list view or search URI so it can't generate a sensible panel.

Test Plan
  • Added a changeset panel to a dashboard.
  • Before: entire dashboard fataled.
  • After: panel fataled narrowly, menu fatals narrowly, dashboard no longer permits creation of another Changeset query panel.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sat, Nov 9, 1:12 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Nov 9, 1:13 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.