Page MenuHomePhabricator

Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation
ClosedPublic

Authored by epriestley on Nov 9 2019, 1:12 AM.
Tags
None
Referenced Files
F18805946: D20902.diff
Sat, Oct 18, 5:06 PM
F18745499: D20902.id49821.diff
Fri, Oct 3, 7:26 AM
F18734101: D20902.id.diff
Tue, Sep 30, 10:48 PM
F18685235: D20902.id.diff
Fri, Sep 26, 10:48 AM
F18646024: D20902.diff
Sep 19 2025, 9:07 AM
F18634013: D20902.diff
Sep 16 2025, 9:22 PM
F18626348: D20902.id49820.diff
Sep 16 2025, 1:05 AM
F18611349: D20902.diff
Sep 14 2025, 6:48 AM
Subscribers
None

Details

Summary

Fixes T13443. When a panel raises an exception during edit action generation, it currently escapes to top level. Instead, catch it more narrowly.

Additionally, mark "ChangesetSearchEngine" as not being a suitable search engine for use in query panels. There's no list view or search URI so it can't generate a sensible panel.

Test Plan
  • Added a changeset panel to a dashboard.
  • Before: entire dashboard fataled.
  • After: panel fataled narrowly, menu fatals narrowly, dashboard no longer permits creation of another Changeset query panel.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 9 2019, 1:13 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.