D8981.id21313.diff
No OneTemporary
Actions

Size

980 B

Referenced Files

None

Subscribers

None

D8981.id21313.diff
View Options

	diff --git a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
	--- a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
	+++ b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
	@@ -637,9 +637,19 @@

	foreach (Filesystem::listDirectory($directory) as $path) {
	$full_path = $directory.DIRECTORY_SEPARATOR.$path;
	- if (is_executable($full_path)) {
	- $executables[] = $full_path;
	+ if (!is_executable($full_path)) {
	+ // Don't include non-executable files.
	+ continue;
	}
	+
	+ if (basename($full_path) == 'README') {
	+ // Don't include README, even if it is marked as executable. It almost
	+ // certainly got caught in the crossfire of a sweeping `chmod`, since
	+ // users do this with some frequency.
	+ continue;
	+ }
	+
	+ $executables[] = $full_path;
	}

	return $executables;