D9227.id21913.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D9227.id21913.diff
View Options

	diff --git a/src/applications/diffusion/controller/DiffusionBrowseFileController.php b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
	--- a/src/applications/diffusion/controller/DiffusionBrowseFileController.php
	+++ b/src/applications/diffusion/controller/DiffusionBrowseFileController.php
	@@ -413,6 +413,7 @@

	$callsign = $repository->getCallsign();
	$editor_link = $user->loadEditorLink($path, $line, $callsign);
	+ $template = $user->loadEditorLink($path, '%l', $callsign);

	$icon_edit = id(new PHUIIconView())
	->setIconFont('fa-pencil');
	@@ -421,6 +422,8 @@
	->setText(pht('Open in Editor'))
	->setHref($editor_link)
	->setIcon($icon_edit)
	+ ->setID('editor_link')
	+ ->setMetadata(array('link_template' => $template))
	->setDisabled(!$editor_link);

	return $button;
	diff --git a/webroot/rsrc/js/core/behavior-line-linker.js b/webroot/rsrc/js/core/behavior-line-linker.js
	--- a/webroot/rsrc/js/core/behavior-line-linker.js
	+++ b/webroot/rsrc/js/core/behavior-line-linker.js
	@@ -10,6 +10,7 @@
	var origin = null;
	var target = null;
	var root = null;
	+ var editor_link = JX.$('editor_link');

	function getRowNumber(tr) {
	var th = JX.DOM.find(tr, 'th', 'phabricator-source-line');
	@@ -79,6 +80,10 @@
	target = null;
	e.kill();
	JX.History.replace(uri);
	+ if (editor_link.href) {
	+ editdata = JX.Stratcom.getData(editor_link);
	+ editor_link.href = editdata.link_template.replace('%25l', o);
	+ }
	});

	});