Page MenuHomePhabricator

Diffusion browser: Update editor link when clicking on a line
ClosedPublic

Authored by avivey on May 20 2014, 11:00 PM.
Tags
None
Referenced Files
F15742304: D9227.id.diff
Thu, May 29, 10:16 PM
Unknown Object (File)
Wed, May 28, 2:52 PM
Unknown Object (File)
Fri, May 9, 5:14 AM
Unknown Object (File)
Fri, May 9, 12:38 AM
Unknown Object (File)
Thu, May 8, 12:33 AM
Unknown Object (File)
Thu, May 8, 12:23 AM
Unknown Object (File)
Wed, May 7, 7:50 AM
Unknown Object (File)
Apr 28 2025, 10:22 PM
Subscribers

Details

Summary

Highlighing and URL are fixed on click - now the edit button too.

Test Plan

click on lines with and without value in "Editr Link" (And without %l in it).

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avivey retitled this revision from to Diffusion browser: Update editor link when clicking on a line.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added a reviewer: epriestley.

This actually doesn't work if the Editor Link has %25l literal in it. I could "fix" it by adding '%25' => '%%325' conversion in loadEditorLink(), but it would still be wrong for %%25l...

epriestley edited edge metadata.

e h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h h . . . okay

This revision is now accepted and ready to land.May 22 2014, 10:33 PM
epriestley updated this revision to Diff 21998.

Closed by commit rP9bba4cda2fe5 (authored by @avivey, committed by @epriestley).