Page MenuHomePhabricator
Files F13391444

D10081.diff
No OneTemporary
Actions

D10081.diff
View Options

diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php
--- a/src/applications/maniphest/storage/ManiphestTask.php
+++ b/src/applications/maniphest/storage/ManiphestTask.php
@@ -159,6 +159,7 @@
return array(
$this->getPriority(),
-$this->getSubpriority(),
+ $this->getID(),
);
}
diff --git a/webroot/rsrc/js/application/projects/behavior-project-boards.js b/webroot/rsrc/js/application/projects/behavior-project-boards.js
--- a/webroot/rsrc/js/application/projects/behavior-project-boards.js
+++ b/webroot/rsrc/js/application/projects/behavior-project-boards.js
@@ -29,10 +29,11 @@
var vd = JX.Stratcom.getData(v).sort || [];
for (var ii = 0; ii < ud.length; ii++) {
- if (ud[ii] < vd[ii]) {
+
+ if (parseInt(ud[ii]) < parseInt(vd[ii])) {
return 1;
}
- if (ud[ii] > vd[ii]) {
+ if (parseInt(ud[ii]) > parseInt(vd[ii])) {
return -1;
}
}
@@ -108,10 +109,11 @@
lists[ii].setGroup(lists);
}
- var onedit = function(card, column, r) {
+ var onedit = function(column, r) {
var new_card = JX.$H(r.tasks).getNode();
var new_data = JX.Stratcom.getData(new_card);
var items = finditems(column);
+ var edited = false;
for (var ii = 0; ii < items.length; ii++) {
var item = items[ii];
@@ -122,11 +124,18 @@
if (phid == new_data.objectPHID) {
items[ii] = new_card;
data = new_data;
+ edited = true;
}
data.sort = r.data.sortMap[data.objectPHID] || data.sort;
}
+ // this is an add then...!
+ if (!edited) {
+ items[items.length + 1] = new_card;
+ new_data.sort = r.data.sortMap[new_data.objectPHID] || new_data.sort;
+ }
+
items.sort(colsort);
JX.DOM.setContent(column, items);
@@ -137,13 +146,12 @@
['edit-project-card'],
function(e) {
e.kill();
- var card = e.getNode('project-card');
var column = e.getNode('project-column');
var request_data = {
'responseType' : 'card',
'columnPHID' : JX.Stratcom.getData(column).columnPHID };
new JX.Workflow(e.getNode('tag:a').href, request_data)
- .setHandler(JX.bind(null, onedit, card, column))
+ .setHandler(JX.bind(null, onedit, column))
.start();
});
@@ -167,7 +175,7 @@
}
}
new JX.Workflow(config.createURI, request_data)
- .setHandler(JX.bind(null, onedit, null, column))
+ .setHandler(JX.bind(null, onedit, column))
.start();
});
});

File Metadata

Mime Type
text/plain
Expires
Wed, Jul 3, 9:48 AM (2 d, 19 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6287807
Default Alt Text
D10081.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility