Page MenuHomePhabricator

D7999.id18097.diff
No OneTemporary

D7999.id18097.diff

Index: src/markup/engine/__tests__/remarkup/underline.txt
===================================================================
--- src/markup/engine/__tests__/remarkup/underline.txt
+++ src/markup/engine/__tests__/remarkup/underline.txt
@@ -2,10 +2,12 @@
__underlined text__
__This is a great idea___ die forever please
__
+/__notunderlined__/ and also /__notunderlined__.c
~~~~~~~~~~
<p>omg__ wtf_____ bbq___ lol__
<u>underlined text</u>
<u>This is a great idea_</u> die forever please
-__</p>
+__
+/__notunderlined__/ and also /__notunderlined__.c</p>
~~~~~~~~~~
-omg__ wtf_____ bbq___ lol__ __underlined text__ __This is a great idea___ die forever please __
+omg__ wtf_____ bbq___ lol__ __underlined text__ __This is a great idea___ die forever please __ /__notunderlined__/ and also /__notunderlined__.c
Index: src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleUnderline.php
===================================================================
--- src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleUnderline.php
+++ src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleUnderline.php
@@ -13,7 +13,7 @@
}
return $this->replaceHTML(
- '@(?<!_)__([^\s_].*?_*)__@s',
+ '@(?<!_|/)__([^\s_/].*?_*)__(?!/|\.\S)@s',
array($this, 'applyCallback'),
$text);
}

File Metadata

Mime Type
text/plain
Expires
Sun, Jun 30, 6:21 PM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6275060
Default Alt Text
D7999.id18097.diff (1 KB)

Event Timeline