Page MenuHomePhabricator
Files F13321391

D11960.diff
No OneTemporary
Actions

D11960.diff
View Options

diff --git a/src/applications/fact/controller/PhabricatorFactChartController.php b/src/applications/fact/controller/PhabricatorFactChartController.php
--- a/src/applications/fact/controller/PhabricatorFactChartController.php
+++ b/src/applications/fact/controller/PhabricatorFactChartController.php
@@ -76,8 +76,8 @@
'colors' => array('#0000ff'),
));
- $panel = new AphrontPanelView();
- $panel->setHeader('Count of '.$spec->getName());
+ $panel = new PHUIObjectBoxView();
+ $panel->setHeaderText(pht('Count of %s', $spec->getName()));
$panel->appendChild($chart);
$crumbs = $this->buildApplicationCrumbs();
@@ -89,8 +89,7 @@
$panel,
),
array(
- 'title' => 'Chart',
- 'device' => false,
+ 'title' => pht('Chart'),
));
}
diff --git a/src/applications/fact/controller/PhabricatorFactHomeController.php b/src/applications/fact/controller/PhabricatorFactHomeController.php
--- a/src/applications/fact/controller/PhabricatorFactHomeController.php
+++ b/src/applications/fact/controller/PhabricatorFactHomeController.php
@@ -42,8 +42,8 @@
$table = new AphrontTableView($rows);
$table->setHeaders(
array(
- 'Fact',
- 'Value',
+ pht('Fact'),
+ pht('Value'),
));
$table->setColumnClasses(
array(
@@ -51,8 +51,8 @@
'n',
));
- $panel = new AphrontPanelView();
- $panel->setHeader('Facts!');
+ $panel = new PHUIObjectBoxView();
+ $panel->setHeaderText(pht('Facts'));
$panel->appendChild($table);
$chart_form = $this->buildChartForm();
@@ -67,8 +67,7 @@
$panel,
),
array(
- 'title' => 'Facts',
- 'device' => false,
+ 'title' => pht('Facts'),
));
}
@@ -98,7 +97,7 @@
if (!$options) {
return id(new PHUIInfoView())
- ->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
+ ->setSeverity(PHUIInfoView::SEVERITY_NODATA)
->setTitle(pht('No Chartable Facts'))
->appendChild(phutil_tag(
'p',
@@ -115,12 +114,11 @@
->setOptions($options))
->appendChild(
id(new AphrontFormSubmitControl())
- ->setValue('Plot Chart'));
+ ->setValue(pht('Plot Chart')));
- $panel = new AphrontPanelView();
- $panel->appendChild($form);
- $panel->setWidth(AphrontPanelView::WIDTH_FORM);
- $panel->setHeader('Plot Chart');
+ $panel = new PHUIObjectBoxView();
+ $panel->setForm($form);
+ $panel->setHeaderText(pht('Plot Chart'));
return $panel;
}

File Metadata

Mime Type
text/plain
Expires
Sat, Jun 15, 6:48 AM (3 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6287427
Default Alt Text
D11960.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility