Differential D11960

Modernize Fact a bit
ClosedPublic
Actions

Authored by chad on Mar 3 2015, 9:03 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7427: Remove remaining AphrontPanelViews

Commits

Restricted Diffusion Commit
rP972c363a2146: Modernize Fact a bit

Summary

Remove AphrontPanels, use standard UI, test for mobile, add phts

Test Plan

Faked a few facts for layout purposes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28798.Mar 3 2015, 9:03 PM

chad retitled this revision from to Modernize Fact a bit.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 3 2015, 9:03 PM

epriestley accepted this revision.Mar 3 2015, 9:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2015, 9:19 PM

Closed by commit rP972c363a2146: Modernize Fact a bit (authored by chad, committed by chad). · Explain WhyMar 3 2015, 9:48 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T7427: Remove remaining AphrontPanelViews.Mar 3 2015, 9:52 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

fact/

controller/

PhabricatorFactChartController.php

7 lines

PhabricatorFactHomeController.php

22 lines

Diff 28800

View Options

src/applications/fact/controller/PhabricatorFactChartController.php