Differential D11960

Modernize Fact a bit
ClosedPublic
Actions

Authored by chad on Mar 3 2015, 9:03 PM.

Tags

None

Referenced Files

	F13396903: D11960.diff
	Thu, Jul 4, 4:50 AM

	F13376043: D11960.diff
	Sat, Jun 29, 2:21 AM

	F13374364: D11960.id28800.diff
	Sat, Jun 29, 12:30 AM

	F13349251: D11960.diff
	Sun, Jun 23, 4:13 AM

	F13340498: D11960.id28798.diff
	Thu, Jun 20, 2:33 AM

	F13334566: D11960.diff
	Tue, Jun 18, 11:56 PM

	F13321391: D11960.diff
	Fri, Jun 14, 6:48 AM

	F13286969: D11960.diff
	Jun 4 2024, 8:01 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7427: Remove remaining AphrontPanelViews

Commits

Restricted Diffusion Commit
rP972c363a2146: Modernize Fact a bit

Summary

Remove AphrontPanels, use standard UI, test for mobile, add phts

Test Plan

Faked a few facts for layout purposes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 28798.Mar 3 2015, 9:03 PM

chad retitled this revision from to Modernize Fact a bit.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 3 2015, 9:03 PM

epriestley accepted this revision.Mar 3 2015, 9:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 3 2015, 9:19 PM

Closed by commit rP972c363a2146: Modernize Fact a bit (authored by chad, committed by chad). · Explain WhyMar 3 2015, 9:48 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T7427: Remove remaining AphrontPanelViews.Mar 3 2015, 9:52 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

fact/

controller/

PhabricatorFactChartController.php

7 lines

PhabricatorFactHomeController.php

22 lines

Diff 28800

View Options

src/applications/fact/controller/PhabricatorFactChartController.php