Page MenuHomePhabricator

D17242.diff
No OneTemporary

D17242.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -439,7 +439,7 @@
'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
'rsrc/js/application/policy/behavior-policy-control.js' => 'd0c516d5',
'rsrc/js/application/policy/behavior-policy-rule-editor.js' => '5e9f347c',
- 'rsrc/js/application/projects/WorkboardBoard.js' => 'fe7cb52a',
+ 'rsrc/js/application/projects/WorkboardBoard.js' => '8935deef',
'rsrc/js/application/projects/WorkboardCard.js' => 'c587b80f',
'rsrc/js/application/projects/WorkboardColumn.js' => '21df4ff5',
'rsrc/js/application/projects/WorkboardController.js' => '55baf5ed',
@@ -765,7 +765,7 @@
'javelin-view-renderer' => '6c2b09a2',
'javelin-view-visitor' => 'efe49472',
'javelin-websocket' => 'e292eaf4',
- 'javelin-workboard-board' => 'fe7cb52a',
+ 'javelin-workboard-board' => '8935deef',
'javelin-workboard-card' => 'c587b80f',
'javelin-workboard-column' => '21df4ff5',
'javelin-workboard-controller' => '55baf5ed',
@@ -1573,6 +1573,15 @@
'javelin-stratcom',
'javelin-dom',
),
+ '8935deef' => array(
+ 'javelin-install',
+ 'javelin-dom',
+ 'javelin-util',
+ 'javelin-stratcom',
+ 'javelin-workflow',
+ 'phabricator-draggable-list',
+ 'javelin-workboard-column',
+ ),
'8a41885b' => array(
'javelin-install',
'javelin-dom',
@@ -2249,15 +2258,6 @@
'javelin-view-visitor',
'javelin-util',
),
- 'fe7cb52a' => array(
- 'javelin-install',
- 'javelin-dom',
- 'javelin-util',
- 'javelin-stratcom',
- 'javelin-workflow',
- 'phabricator-draggable-list',
- 'javelin-workboard-column',
- ),
'fea0eb47' => array(
'javelin-install',
),
diff --git a/webroot/rsrc/js/application/projects/WorkboardBoard.js b/webroot/rsrc/js/application/projects/WorkboardBoard.js
--- a/webroot/rsrc/js/application/projects/WorkboardBoard.js
+++ b/webroot/rsrc/js/application/projects/WorkboardBoard.js
@@ -204,7 +204,14 @@
if (!this._templates[phid]) {
for (var add_phid in response.columnMaps) {
- this.getColumn(add_phid).newCard(phid);
+ var target_column = this.getColumn(add_phid);
+
+ if (!target_column) {
+ // If the column isn't visible, don't try to add a card to it.
+ continue;
+ }
+
+ target_column.newCard(phid);
}
}

File Metadata

Mime Type
text/plain
Expires
Fri, Jun 14, 10:13 AM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6296518
Default Alt Text
D17242.diff (2 KB)

Event Timeline