Page MenuHomePhabricator

Fix a JS error when adding a project card directly to a subproject from a workboard
ClosedPublic

Authored by epriestley on Jan 24 2017, 3:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:28 AM
Unknown Object (File)
Thu, Apr 11, 3:53 AM
Unknown Object (File)
Thu, Apr 11, 3:53 AM
Unknown Object (File)
Thu, Apr 11, 3:53 AM
Unknown Object (File)
Wed, Apr 10, 6:20 PM
Unknown Object (File)
Tue, Apr 9, 12:19 PM
Unknown Object (File)
Sun, Apr 7, 12:26 PM
Unknown Object (File)
Sun, Mar 31, 4:37 AM
Subscribers
None

Details

Summary

Fixes T12152. When creating a subproject task directly from a parent project, we can get column information back about the subproject column, which isn't visible. Just ignore this rather than trying to draw a card into a column which does not exist.

This flow (see test plan) is a little unintuitive since the card never appears on the workboard, but this class of things is probably roughly somewhere in T4900.

Test Plan
  • Create a parent project A.
  • Create subproject B.
  • On the workboard for A, select "Create Task..." from the dropdown.
  • Add tag "B" in the dialog that pops up.
  • Save the task.

Note that this flow creates a task tagged only with "B", since "A" and "B" are mutually exclusive tags.

Before patch: UI freezes (JX.Mask is never removed), JS error in console.
After patch: workflow completes. Note that card is (correctly) not visible: it's in an invisible subproject column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable