Page MenuHomePhabricator

Fix a JS error when adding a project card directly to a subproject from a workboard
ClosedPublic

Authored by epriestley on Jan 24 2017, 3:31 PM.
Tags
None
Referenced Files
F18865887: D17242.id41469.diff
Mon, Nov 3, 2:28 PM
F18853047: D17242.id41469.diff
Fri, Oct 31, 1:55 PM
F18724295: D17242.diff
Sep 30 2025, 3:29 AM
F18695723: D17242.id41468.diff
Sep 27 2025, 6:27 AM
F18665482: D17242.id.diff
Sep 24 2025, 2:39 AM
F18598516: D17242.diff
Sep 13 2025, 5:12 AM
F18591060: D17242.diff
Sep 12 2025, 8:08 AM
F18527570: D17242.id41468.diff
Sep 6 2025, 7:06 PM
Subscribers
None

Details

Summary

Fixes T12152. When creating a subproject task directly from a parent project, we can get column information back about the subproject column, which isn't visible. Just ignore this rather than trying to draw a card into a column which does not exist.

This flow (see test plan) is a little unintuitive since the card never appears on the workboard, but this class of things is probably roughly somewhere in T4900.

Test Plan
  • Create a parent project A.
  • Create subproject B.
  • On the workboard for A, select "Create Task..." from the dropdown.
  • Add tag "B" in the dialog that pops up.
  • Save the task.

Note that this flow creates a task tagged only with "B", since "A" and "B" are mutually exclusive tags.

Before patch: UI freezes (JX.Mask is never removed), JS error in console.
After patch: workflow completes. Note that card is (correctly) not visible: it's in an invisible subproject column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable