Page MenuHomePhabricator

Fix a JS error when adding a project card directly to a subproject from a workboard
ClosedPublic

Authored by epriestley on Jan 24 2017, 3:31 PM.
Tags
None
Referenced Files
F15581454: D17242.diff
Wed, May 7, 11:03 AM
F15580581: D17242.diff
Wed, May 7, 6:31 AM
F15552120: D17242.id.diff
Sun, Apr 27, 7:23 PM
F15544205: D17242.id41468.diff
Sat, Apr 26, 3:36 AM
F15544203: D17242.id41469.diff
Sat, Apr 26, 3:35 AM
F15544200: D17242.id.diff
Sat, Apr 26, 3:35 AM
F15531845: D17242.id41468.diff
Wed, Apr 23, 1:24 PM
F15531844: D17242.id41469.diff
Wed, Apr 23, 1:24 PM
Subscribers
None

Details

Summary

Fixes T12152. When creating a subproject task directly from a parent project, we can get column information back about the subproject column, which isn't visible. Just ignore this rather than trying to draw a card into a column which does not exist.

This flow (see test plan) is a little unintuitive since the card never appears on the workboard, but this class of things is probably roughly somewhere in T4900.

Test Plan
  • Create a parent project A.
  • Create subproject B.
  • On the workboard for A, select "Create Task..." from the dropdown.
  • Add tag "B" in the dialog that pops up.
  • Save the task.

Note that this flow creates a task tagged only with "B", since "A" and "B" are mutually exclusive tags.

Before patch: UI freezes (JX.Mask is never removed), JS error in console.
After patch: workflow completes. Note that card is (correctly) not visible: it's in an invisible subproject column.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable