Page MenuHomePhabricator
Files F13292041

D14416.id34826.diff
No OneTemporary
Actions

D14416.id34826.diff
View Options

diff --git a/src/applications/badges/controller/PhabricatorBadgesViewController.php b/src/applications/badges/controller/PhabricatorBadgesViewController.php
--- a/src/applications/badges/controller/PhabricatorBadgesViewController.php
+++ b/src/applications/badges/controller/PhabricatorBadgesViewController.php
@@ -64,6 +64,9 @@
$add_comment = $this->buildCommentForm($badge);
+ $timeline->setQuoteTargetID($add_comment->getCommentID());
+ $timeline->setQuoteRef('???');
+
return $this->buildApplicationPage(
array(
$crumbs,
diff --git a/src/applications/countdown/controller/PhabricatorCountdownViewController.php b/src/applications/countdown/controller/PhabricatorCountdownViewController.php
--- a/src/applications/countdown/controller/PhabricatorCountdownViewController.php
+++ b/src/applications/countdown/controller/PhabricatorCountdownViewController.php
@@ -61,6 +61,9 @@
$add_comment = $this->buildCommentForm($countdown);
+ $timeline->setQuoteTargetID($add_comment->getCommentID());
+ $timeline->setQuoteRef($countdown->getMonogram());
+
$content = array(
$crumbs,
$object_box,
diff --git a/src/applications/files/controller/PhabricatorFileInfoController.php b/src/applications/files/controller/PhabricatorFileInfoController.php
--- a/src/applications/files/controller/PhabricatorFileInfoController.php
+++ b/src/applications/files/controller/PhabricatorFileInfoController.php
@@ -102,6 +102,9 @@
->setAction($this->getApplicationURI('/comment/'.$file->getID().'/'))
->setSubmitButtonName(pht('Add Comment'));
+ $timeline->setQuoteTargetID($add_comment_form->getCommentID());
+ $timeline->setQuoteRef($file->getMonogram());
+
return array(
$timeline,
$add_comment_form,
diff --git a/src/applications/legalpad/controller/LegalpadDocumentManageController.php b/src/applications/legalpad/controller/LegalpadDocumentManageController.php
--- a/src/applications/legalpad/controller/LegalpadDocumentManageController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentManageController.php
@@ -52,6 +52,9 @@
$add_comment = $this->buildAddCommentView($document, $comment_form_id);
+ $timeline->setQuoteTargetID($add_comment->getCommentID());
+ $timeline->setQuoteRef($document->getMonogram());
+
$crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
$crumbs->addTextCrumb(
$document->getMonogram(),
diff --git a/src/applications/macro/controller/PhabricatorMacroViewController.php b/src/applications/macro/controller/PhabricatorMacroViewController.php
--- a/src/applications/macro/controller/PhabricatorMacroViewController.php
+++ b/src/applications/macro/controller/PhabricatorMacroViewController.php
@@ -75,6 +75,9 @@
->setAction($this->getApplicationURI('/comment/'.$macro->getID().'/'))
->setSubmitButtonName(pht('Add Comment'));
+ $timeline->setQuoteTargetID($add_comment_form->getCommentID());
+ $timeline->setQuoteRef('???');
+
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)
->addPropertyList($properties);
diff --git a/src/applications/paste/controller/PhabricatorPasteViewController.php b/src/applications/paste/controller/PhabricatorPasteViewController.php
--- a/src/applications/paste/controller/PhabricatorPasteViewController.php
+++ b/src/applications/paste/controller/PhabricatorPasteViewController.php
@@ -67,7 +67,7 @@
$source_code);
$crumbs = $this->buildApplicationCrumbs()
- ->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID());
+ ->addTextCrumb('P'.$paste->getID(), '/'.$paste->getMonogram());
$timeline = $this->buildTransactionTimeline(
$paste,
@@ -89,6 +89,9 @@
->setAction($this->getApplicationURI('/comment/'.$paste->getID().'/'))
->setSubmitButtonName(pht('Add Comment'));
+ $timeline->setQuoteTargetID($add_comment_form->getCommentID());
+ $timeline->setQuoteRef($paste->getMonogram());
+
return $this->newPage()
->setTitle($paste->getFullName())
->setCrumbs($crumbs)
diff --git a/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php b/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
--- a/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
+++ b/src/applications/slowvote/controller/PhabricatorSlowvotePollController.php
@@ -57,6 +57,9 @@
new PhabricatorSlowvoteTransactionQuery());
$add_comment = $this->buildCommentForm($poll);
+ $timeline->setQuoteTargetID($add_comment->getCommentID());
+ $timeline->setQuoteRef($poll->getMonogram());
+
$object_box = id(new PHUIObjectBoxView())
->setHeader($header)
->addPropertyList($properties);
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
@@ -225,7 +225,7 @@
return $this->statusID;
}
- private function getCommentID() {
+ public function getCommentID() {
if (!$this->commentID) {
$this->commentID = celerity_generate_unique_node_id();
}

File Metadata

Mime Type
text/plain
Expires
Thu, Jun 6, 1:13 AM (3 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6327507
Default Alt Text
D14416.id34826.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility