Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13213064
D14131.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
10 KB
Referenced Files
None
Subscribers
None
D14131.diff
View Options
diff --git a/src/applications/badges/controller/PhabricatorBadgesViewController.php b/src/applications/badges/controller/PhabricatorBadgesViewController.php
--- a/src/applications/badges/controller/PhabricatorBadgesViewController.php
+++ b/src/applications/badges/controller/PhabricatorBadgesViewController.php
@@ -109,7 +109,8 @@
'default',
$viewer);
- $view->addSectionHeader(pht('Description'));
+ $view->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$view->addTextContent($description);
}
diff --git a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
--- a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
@@ -201,7 +201,8 @@
id(new PhabricatorMarkupOneOff())->setContent($description),
'default',
$viewer);
- $view->addSectionHeader(pht('Description'));
+ $view->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$view->addTextContent($description);
return $view;
diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php
--- a/src/applications/diffusion/controller/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseController.php
@@ -156,7 +156,8 @@
$tag = idx($tags, $symbolic);
if ($tag && strlen($tag->getMessage())) {
- $view->addSectionHeader(pht('Tag Content'));
+ $view->addSectionHeader(
+ pht('Tag Content'), 'fa-tag');
$view->addTextContent($this->markupText($tag->getMessage()));
}
}
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryController.php b/src/applications/diffusion/controller/DiffusionRepositoryController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryController.php
@@ -289,7 +289,8 @@
$repository,
'description',
$user);
- $view->addSectionHeader(pht('Description'));
+ $view->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$view->addTextContent($description);
}
diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
@@ -294,7 +294,8 @@
$this->buildRepositoryUpdateInterval($repository));
$description = $repository->getDetail('description');
- $view->addSectionHeader(pht('Description'));
+ $view->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
if (!strlen($description)) {
$description = phutil_tag('em', array(), pht('No description provided.'));
} else {
diff --git a/src/applications/drydock/controller/DrydockLeaseViewController.php b/src/applications/drydock/controller/DrydockLeaseViewController.php
--- a/src/applications/drydock/controller/DrydockLeaseViewController.php
+++ b/src/applications/drydock/controller/DrydockLeaseViewController.php
@@ -121,7 +121,8 @@
$attributes = $lease->getAttributes();
if ($attributes) {
- $view->addSectionHeader(pht('Attributes'));
+ $view->addSectionHeader(
+ pht('Attributes'), 'fa-list-ul');
foreach ($attributes as $key => $value) {
$view->addProperty($key, $value);
}
diff --git a/src/applications/drydock/controller/DrydockResourceViewController.php b/src/applications/drydock/controller/DrydockResourceViewController.php
--- a/src/applications/drydock/controller/DrydockResourceViewController.php
+++ b/src/applications/drydock/controller/DrydockResourceViewController.php
@@ -117,7 +117,8 @@
$attributes = $resource->getAttributes();
if ($attributes) {
- $view->addSectionHeader(pht('Attributes'));
+ $view->addSectionHeader(
+ pht('Attributes'), 'fa-list-ul');
foreach ($attributes as $key => $value) {
$view->addProperty($key, $value);
}
diff --git a/src/applications/fund/controller/FundInitiativeViewController.php b/src/applications/fund/controller/FundInitiativeViewController.php
--- a/src/applications/fund/controller/FundInitiativeViewController.php
+++ b/src/applications/fund/controller/FundInitiativeViewController.php
@@ -103,7 +103,8 @@
'default',
$viewer);
- $view->addSectionHeader(pht('Description'));
+ $view->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$view->addTextContent($description);
}
@@ -114,7 +115,8 @@
'default',
$viewer);
- $view->addSectionHeader(pht('Risks/Challenges'));
+ $view->addSectionHeader(
+ pht('Risks/Challenges'), 'fa-ambulance');
$view->addTextContent($risks);
}
diff --git a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
--- a/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+++ b/src/applications/harbormaster/controller/HarbormasterBuildViewController.php
@@ -186,7 +186,8 @@
'default',
$viewer);
- $properties->addSectionHeader(pht('Description'));
+ $properties->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$properties->addTextContent($rendered);
}
} else {
diff --git a/src/applications/legalpad/controller/LegalpadDocumentManageController.php b/src/applications/legalpad/controller/LegalpadDocumentManageController.php
--- a/src/applications/legalpad/controller/LegalpadDocumentManageController.php
+++ b/src/applications/legalpad/controller/LegalpadDocumentManageController.php
@@ -84,7 +84,8 @@
$view = new PHUIPropertyListView();
$view->addClass('legalpad');
- $view->addSectionHeader(pht('Document'));
+ $view->addSectionHeader(
+ pht('Document'), 'fa-file-text-o');
$view->addTextContent(
$engine->getOutput($body, LegalpadDocumentBody::MARKUP_FIELD_TEXT));
diff --git a/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php b/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
--- a/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
+++ b/src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
@@ -106,8 +106,7 @@
$overview = $application->getOverview();
if ($overview) {
$properties->addSectionHeader(
- pht('Overview'),
- PHUIPropertyListView::ICON_SUMMARY);
+ pht('Overview'), PHUIPropertyListView::ICON_SUMMARY);
$properties->addTextContent(
PhabricatorMarkupEngine::renderOneObject(
id(new PhabricatorMarkupOneOff())->setContent($overview),
@@ -119,7 +118,8 @@
$viewer,
$application);
- $properties->addSectionHeader(pht('Policies'));
+ $properties->addSectionHeader(
+ pht('Policies'), 'fa-lock');
foreach ($application->getCapabilities() as $capability) {
$properties->addProperty(
diff --git a/src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php b/src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php
--- a/src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php
+++ b/src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php
@@ -218,7 +218,8 @@
'Delivery reasons are listed from weakest to strongest.')));
}
- $properties->addSectionHeader(pht('Routing Rules'));
+ $properties->addSectionHeader(
+ pht('Routing Rules'), 'fa-paper-plane-o');
$map = $mail->getDeliveredRoutingMap();
$routing_detail = null;
diff --git a/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php b/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
--- a/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
+++ b/src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
@@ -125,7 +125,8 @@
'default',
$viewer);
- $view->addSectionHeader(pht('Complaint'));
+ $view->addSectionHeader(
+ pht('Complaint'), 'fa-exclamation-circle');
$view->addTextContent($complaint);
}
diff --git a/src/applications/owners/controller/PhabricatorOwnersDetailController.php b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
--- a/src/applications/owners/controller/PhabricatorOwnersDetailController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
@@ -189,7 +189,8 @@
$description = $package->getDescription();
if (strlen($description)) {
- $view->addSectionHeader(pht('Description'));
+ $view->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$view->addTextContent(
$output = PhabricatorMarkupEngine::renderOneObject(
id(new PhabricatorMarkupOneOff())->setContent($description),
diff --git a/src/applications/phortune/controller/PhortuneMerchantViewController.php b/src/applications/phortune/controller/PhortuneMerchantViewController.php
--- a/src/applications/phortune/controller/PhortuneMerchantViewController.php
+++ b/src/applications/phortune/controller/PhortuneMerchantViewController.php
@@ -141,7 +141,8 @@
'default',
$viewer);
- $view->addSectionHeader(pht('Description'));
+ $view->addSectionHeader(
+ pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$view->addTextContent($description);
}
diff --git a/src/view/phui/PHUIPropertyListView.php b/src/view/phui/PHUIPropertyListView.php
--- a/src/view/phui/PHUIPropertyListView.php
+++ b/src/view/phui/PHUIPropertyListView.php
@@ -10,8 +10,8 @@
private $classes = array();
private $stacked;
- const ICON_SUMMARY = 'fa-align-left bluegrey';
- const ICON_TESTPLAN = 'fa-file-text-o bluegrey';
+ const ICON_SUMMARY = 'fa-align-left';
+ const ICON_TESTPLAN = 'fa-file-text-o';
protected function canAppendChild() {
return false;
@@ -247,7 +247,7 @@
$name = $part['name'];
if ($part['icon']) {
$icon = id(new PHUIIconView())
- ->setIconFont($part['icon']);
+ ->setIconFont($part['icon'].' bluegrey');
$name = phutil_tag(
'span',
array(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, May 18, 7:20 AM (2 w, 5 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6299764
Default Alt Text
D14131.diff (10 KB)
Attached To
Mode
D14131: Make icon setting in Section Headers easier/consistent
Attached
Detach File
Event Timeline
Log In to Comment