Page MenuHomePhabricator
Differential D14131

Make icon setting in Section Headers easier/consistent
ClosedPublic
Actions

Authored by chad on Sep 19 2015, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 4:28 AM
Unknown Object (File)
Sun, Dec 8, 11:00 PM
Unknown Object (File)
Sun, Dec 8, 5:00 AM
Unknown Object (File)
Wed, Dec 4, 6:39 PM
Unknown Object (File)
Wed, Dec 4, 6:39 PM
Unknown Object (File)
Wed, Dec 4, 6:39 PM
Unknown Object (File)
Wed, Dec 4, 6:39 PM
Unknown Object (File)
Wed, Dec 4, 6:19 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP666f19e50491: Make icon setting in Section Headers easier/consistent
Summary

You can already pass other icons, but this makes it a bit simpler.

Test Plan

Test Maniphest, Badges

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 34134.Sep 19 2015, 4:52 PM
chad retitled this revision from to Make icon setting in Section Headers easier/consistent.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 19 2015, 4:52 PM
chad updated this revision to Diff 34135.Sep 19 2015, 5:37 PM
  • add missing icons
epriestley accepted this revision.Sep 19 2015, 6:10 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 19 2015, 6:10 PM
Closed by commit rP666f19e50491: Make icon setting in Section Headers easier/consistent (authored by chad, committed by chad). · Explain WhySep 19 2015, 6:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 34136

View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...
View Options

src/applications/drydock/controller/DrydockLeaseViewController.php

Loading...
View Options

src/applications/drydock/controller/DrydockResourceViewController.php

Loading...
View Options

src/applications/fund/controller/FundInitiativeViewController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentManageController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

Loading...
View Options

src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php

Loading...
View Options

src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/phortune/controller/PhortuneMerchantViewController.php

Loading...
View Options

src/view/phui/PHUIPropertyListView.php

Loading...
Phabricator · Built by Phacility