Page MenuHomePhabricator
Files F13206657

D10928.diff
No OneTemporary
Actions

D10928.diff
View Options

diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php
@@ -71,22 +71,26 @@
$xaction->save();
$xaction->attachComment($comment);
- $object = id(new PhabricatorObjectQuery())
- ->withPHIDs(array($xaction->getObjectPHID()))
- ->setViewer($this->getActor())
- ->executeOne();
- if ($object &&
- $object instanceof PhabricatorApplicationTransactionInterface) {
- $editor = $object->getApplicationTransactionEditor();
- $editor->setActor($this->getActor());
- $support_xactions = $editor->getExpandedSupportTransactions(
- $object,
- $xaction);
- if ($support_xactions) {
- $editor
- ->setContentSource($this->getContentSource())
- ->setContinueOnNoEffect(true)
- ->applyTransactions($object, $support_xactions);
+ // For comment edits, we need to make sure there are no automagical
+ // transactions like adding mentions or projects.
+ if ($new_version > 1) {
+ $object = id(new PhabricatorObjectQuery())
+ ->withPHIDs(array($xaction->getObjectPHID()))
+ ->setViewer($this->getActor())
+ ->executeOne();
+ if ($object &&
+ $object instanceof PhabricatorApplicationTransactionInterface) {
+ $editor = $object->getApplicationTransactionEditor();
+ $editor->setActor($this->getActor());
+ $support_xactions = $editor->getExpandedSupportTransactions(
+ $object,
+ $xaction);
+ if ($support_xactions) {
+ $editor
+ ->setContentSource($this->getContentSource())
+ ->setContinueOnNoEffect(true)
+ ->applyTransactions($object, $support_xactions);
+ }
}
}
$xaction->endReadLocking();

File Metadata

Mime Type
text/plain
Expires
Thu, May 16, 2:39 PM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6289088
Default Alt Text
D10928.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility