Page MenuHomePhabricator

Transactions - don't bother checking for fancy transactions on comment create
ClosedPublic

Authored by btrahan on Dec 4 2014, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 8:28 PM
Unknown Object (File)
Sat, Feb 15, 10:26 AM
Unknown Object (File)
Mon, Feb 10, 1:35 PM
Unknown Object (File)
Fri, Feb 7, 9:38 AM
Unknown Object (File)
Jan 28 2025, 7:10 AM
Unknown Object (File)
Jan 18 2025, 10:03 AM
Unknown Object (File)
Jan 18 2025, 5:25 AM
Unknown Object (File)
Jan 12 2025, 5:43 PM
Subscribers

Details

Summary

Only necessary for edits, only bother if the comment version is greater than 1. Ref T6690. This is another way to fix T6690 -- this check will never run since you can't edit a conpherence comment -- but the fix already applied should happen too to future proof Conpherence.

Test Plan

made a comment on a diff - success. edited the comment and mentions were generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Transactions - don't bother checking for fancy transactions on comment create.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 4 2014, 8:01 PM
This revision was automatically updated to reflect the committed changes.