Differential D10928

Transactions - don't bother checking for fancy transactions on comment create
ClosedPublic
Actions

Authored by btrahan on Dec 4 2014, 7:58 PM.

Tags

None

Referenced Files

	F15378242: D10928.id26248.diff
	Thu, Mar 13, 1:30 PM

	F15378241: D10928.diff
	Thu, Mar 13, 1:30 PM

	F15377865: D10928.diff
	Thu, Mar 13, 11:06 AM

	F15343098: D10928.id26248.diff
	Sun, Mar 9, 10:12 PM

	F15343097: D10928.id.diff
	Sun, Mar 9, 10:12 PM

	F15343095: D10928.diff
	Sun, Mar 9, 10:12 PM

	F15338325: D10928.diff
	Sun, Mar 9, 10:29 AM

	Unknown Object (File)
	Fri, Feb 21, 8:28 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T6690: Exception when creating new Conpherence threads

Commits

Restricted Diffusion Commit
rPa9f0bd9b8fbf: Transactions - don't bother checking for fancy transactions on comment create

Summary

Only necessary for edits, only bother if the comment version is greater than 1. Ref T6690. This is another way to fix T6690 -- this check will never run since you can't edit a conpherence comment -- but the fix already applied should happen too to future proof Conpherence.

Test Plan

made a comment on a diff - success. edited the comment and mentions were generated.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26248.Dec 4 2014, 7:58 PM

btrahan retitled this revision from to Transactions - don't bother checking for fancy transactions on comment create.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T6690: Exception when creating new Conpherence threads.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 4 2014, 7:58 PM

epriestley accepted this revision.Dec 4 2014, 8:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 4 2014, 8:01 PM

Closed by commit rPa9f0bd9b8fbf: Transactions - don't bother checking for fancy transactions on comment create (authored by btrahan, committed by btrahan). · Explain WhyDec 4 2014, 8:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

36 lines

Diff 26249

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...