Page MenuHomePhabricator
Files F13199985

D20037.diff
No OneTemporary
Actions

D20037.diff
View Options

diff --git a/src/applications/passphrase/controller/PassphraseCredentialRevealController.php b/src/applications/passphrase/controller/PassphraseCredentialRevealController.php
--- a/src/applications/passphrase/controller/PassphraseCredentialRevealController.php
+++ b/src/applications/passphrase/controller/PassphraseCredentialRevealController.php
@@ -21,12 +21,8 @@
return new Aphront404Response();
}
- $view_uri = '/K'.$credential->getID();
+ $view_uri = $credential->getURI();
- $token = id(new PhabricatorAuthSessionEngine())->requireHighSecuritySession(
- $viewer,
- $request,
- $view_uri);
$is_locked = $credential->getIsLocked();
if ($is_locked) {
@@ -39,7 +35,7 @@
->addCancelButton($view_uri);
}
- if ($request->isFormPost()) {
+ if ($request->isFormOrHisecPost()) {
$secret = $credential->getSecret();
if (!$secret) {
$body = pht('This credential has no associated secret.');
@@ -76,6 +72,7 @@
$editor = id(new PassphraseCredentialTransactionEditor())
->setActor($viewer)
+ ->setCancelURI($view_uri)
->setContinueOnNoEffect(true)
->setContentSourceFromRequest($request)
->applyTransactions($credential, $xactions);
diff --git a/src/applications/passphrase/storage/PassphraseCredential.php b/src/applications/passphrase/storage/PassphraseCredential.php
--- a/src/applications/passphrase/storage/PassphraseCredential.php
+++ b/src/applications/passphrase/storage/PassphraseCredential.php
@@ -52,6 +52,10 @@
return 'K'.$this->getID();
}
+ public function getURI() {
+ return '/'.$this->getMonogram();
+ }
+
protected function getConfiguration() {
return array(
self::CONFIG_AUX_PHID => true,
diff --git a/src/applications/passphrase/xaction/PassphraseCredentialLookedAtTransaction.php b/src/applications/passphrase/xaction/PassphraseCredentialLookedAtTransaction.php
--- a/src/applications/passphrase/xaction/PassphraseCredentialLookedAtTransaction.php
+++ b/src/applications/passphrase/xaction/PassphraseCredentialLookedAtTransaction.php
@@ -30,4 +30,10 @@
return 'blue';
}
+ public function shouldTryMFA(
+ $object,
+ PhabricatorApplicationTransaction $xaction) {
+ return true;
+ }
+
}

File Metadata

Mime Type
text/plain
Expires
May 14 2024, 8:24 PM (4 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6295633
Default Alt Text
D20037.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility