Page MenuHomePhabricator
Files F13198413

D17976.id43233.diff
No OneTemporary
Actions

D17976.id43233.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -13,7 +13,7 @@
'core.pkg.js' => 'a8eda64a',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => 'bf87589e',
- 'differential.pkg.js' => '43b71dc8',
+ 'differential.pkg.js' => 'f25352b6',
'diffusion.pkg.css' => 'b93d9b8c',
'diffusion.pkg.js' => '84c8f8fd',
'favicon.ico' => '30672e08',
@@ -391,7 +391,7 @@
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
'rsrc/js/application/diff/DiffChangeset.js' => 'cf4e2140',
- 'rsrc/js/application/diff/DiffChangesetList.js' => '5c68c40c',
+ 'rsrc/js/application/diff/DiffChangesetList.js' => '541206ba',
'rsrc/js/application/diff/DiffInline.js' => '77e14b60',
'rsrc/js/application/diff/ScrollObjective.js' => '2e069f79',
'rsrc/js/application/diff/ScrollObjectiveList.js' => '085dd101',
@@ -778,7 +778,7 @@
'phabricator-darkmessage' => 'c48cccdd',
'phabricator-dashboard-css' => 'fe5b1869',
'phabricator-diff-changeset' => 'cf4e2140',
- 'phabricator-diff-changeset-list' => '5c68c40c',
+ 'phabricator-diff-changeset-list' => '541206ba',
'phabricator-diff-inline' => '77e14b60',
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
'phabricator-draggable-list' => 'bea6e7f4',
@@ -1311,6 +1311,10 @@
'5294060f' => array(
'phui-theme-css',
),
+ '541206ba' => array(
+ 'javelin-install',
+ 'phabricator-scroll-objective-list',
+ ),
'54b612ba' => array(
'javelin-color',
'javelin-install',
@@ -1360,10 +1364,6 @@
'javelin-stratcom',
'javelin-dom',
),
- '5c68c40c' => array(
- 'javelin-install',
- 'phabricator-scroll-objective-list',
- ),
'5e2634b9' => array(
'javelin-behavior',
'javelin-aphlict',
diff --git a/webroot/rsrc/js/application/diff/DiffChangesetList.js b/webroot/rsrc/js/application/diff/DiffChangesetList.js
--- a/webroot/rsrc/js/application/diff/DiffChangesetList.js
+++ b/webroot/rsrc/js/application/diff/DiffChangesetList.js
@@ -1358,16 +1358,20 @@
return null;
}
- var v = JX.Vector.getViewport();
+ // We're going to find the changeset which spans an invisible line a
+ // little underneath the bottom of the banner. This makes the header
+ // tick over from "A.txt" to "B.txt" just as "A.txt" scrolls completely
+ // offscreen.
+ var detect_height = 64;
+
for (var ii = 0; ii < this._changesets.length; ii++) {
var changeset = this._changesets[ii];
var c = changeset.getVectors();
- // If the changeset starts above the upper half of the screen...
- if (c.pos.y < (s.y + (v.y / 2))) {
- // ...and ends below the lower half of the screen, this is the
- // current visible changeset.
- if ((c.pos.y + c.dim.y) > (s.y + (v.y / 2))) {
+ // If the changeset starts above the line...
+ if (c.pos.y <= (s.y + detect_height)) {
+ // ...and ends below the line, this is the current visible changeset.
+ if ((c.pos.y + c.dim.y) >= (s.y + detect_height)) {
return changeset;
}
}

File Metadata

Mime Type
text/plain
Expires
Tue, May 14, 6:19 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6294885
Default Alt Text
D17976.id43233.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility