D10137.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D10137.diff
View Options

	diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
	--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
	+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
	@@ -161,11 +161,23 @@
	$requests = mpull($requests, null, 'getAuditorPHID');
	$actor_request = idx($requests, $actor_phid);

	- if ($actor_request) {
	- $actor_request
	- ->setAuditStatus($status_resigned)
	- ->save();
	+ // If the actor doesn't currently have a relationship to the
	+ // commit, add one explicitly. For example, this allows members
	+ // of a project to resign from a commit and have it drop out of
	+ // their queue.
	+
	+ if (!$actor_request) {
	+ $actor_request = id(new PhabricatorRepositoryAuditRequest())
	+ ->setCommitPHID($object->getPHID())
	+ ->setAuditorPHID($actor_phid);
	+
	+ $requests[] = $actor_request;
	+ $object->attachAudits($requests);
	}
	+
	+ $actor_request
	+ ->setAuditStatus($status_resigned)
	+ ->save();
	break;
	case PhabricatorAuditActionConstants::ACCEPT:
	case PhabricatorAuditActionConstants::CONCERN: