Page MenuHomePhabricator

D21540.id.diff
No OneTemporary

D21540.id.diff

diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
--- a/src/applications/base/PhabricatorApplication.php
+++ b/src/applications/base/PhabricatorApplication.php
@@ -490,7 +490,7 @@
return array();
}
- final private function getCustomPolicySetting($capability) {
+ private function getCustomPolicySetting($capability) {
if (!$this->isCapabilityEditable($capability)) {
return null;
}
@@ -516,7 +516,7 @@
}
- final private function getCustomCapabilitySpecification($capability) {
+ private function getCustomCapabilitySpecification($capability) {
$custom = $this->getCustomCapabilities();
if (!isset($custom[$capability])) {
throw new Exception(pht("Unknown capability '%s'!", $capability));
diff --git a/src/applications/differential/storage/DifferentialHunk.php b/src/applications/differential/storage/DifferentialHunk.php
--- a/src/applications/differential/storage/DifferentialHunk.php
+++ b/src/applications/differential/storage/DifferentialHunk.php
@@ -203,7 +203,7 @@
return implode('', $this->makeContent($include));
}
- final private function makeContent($include) {
+ private function makeContent($include) {
$lines = $this->getSplitLines();
$results = array();
diff --git a/src/applications/diffusion/request/DiffusionRequest.php b/src/applications/diffusion/request/DiffusionRequest.php
--- a/src/applications/diffusion/request/DiffusionRequest.php
+++ b/src/applications/diffusion/request/DiffusionRequest.php
@@ -125,7 +125,7 @@
*
* @task new
*/
- final private function __construct() {
+ private function __construct() {
// <private>
}
@@ -138,7 +138,7 @@
* @return DiffusionRequest New request object.
* @task new
*/
- final private static function newFromIdentifier(
+ private static function newFromIdentifier(
$identifier,
PhabricatorUser $viewer,
$need_edit = false) {
@@ -174,7 +174,7 @@
* @return DiffusionRequest New request object.
* @task new
*/
- final private static function newFromRepository(
+ private static function newFromRepository(
PhabricatorRepository $repository) {
$map = array(
@@ -205,7 +205,7 @@
* @return void
* @task new
*/
- final private function initializeFromDictionary(array $data) {
+ private function initializeFromDictionary(array $data) {
$blob = idx($data, 'blob');
if (strlen($blob)) {
$blob = self::parseRequestBlob($blob, $this->supportsBranches());
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -1389,7 +1389,7 @@
return $xactions;
}
- final private function queuePublishing() {
+ private function queuePublishing() {
$object = $this->publishableObject;
$xactions = $this->publishableTransactions;
@@ -4207,7 +4207,7 @@
* @return dict<string, wild> Serializable editor state.
* @task workers
*/
- final private function getWorkerState() {
+ private function getWorkerState() {
$state = array();
foreach ($this->getAutomaticStateProperties() as $property) {
$state[$property] = $this->$property;
@@ -4336,7 +4336,7 @@
* @return map<string, wild> Map of encoded values.
* @task workers
*/
- final private function encodeStateForStorage(
+ private function encodeStateForStorage(
array $state,
array $encodings) {
@@ -4382,7 +4382,7 @@
* @return map<string, wild> Map of decoded values.
* @task workers
*/
- final private function decodeStateFromStorage(
+ private function decodeStateFromStorage(
array $state,
array $encodings) {
diff --git a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
--- a/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
+++ b/src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php
@@ -135,7 +135,7 @@
);
}
- final private function getExternalCursorStringForResult($object) {
+ private function getExternalCursorStringForResult($object) {
$cursor = $this->newExternalCursorStringForResult($object);
if (!is_string($cursor)) {
@@ -154,7 +154,7 @@
return $this->externalCursorString;
}
- final private function setExternalCursorString($external_cursor) {
+ private function setExternalCursorString($external_cursor) {
$this->externalCursorString = $external_cursor;
return $this;
}
@@ -168,17 +168,17 @@
return $this;
}
- final private function getInternalCursorObject() {
+ private function getInternalCursorObject() {
return $this->internalCursorObject;
}
- final private function setInternalCursorObject(
+ private function setInternalCursorObject(
PhabricatorQueryCursor $cursor) {
$this->internalCursorObject = $cursor;
return $this;
}
- final private function getInternalCursorFromExternalCursor(
+ private function getInternalCursorFromExternalCursor(
$cursor_string) {
$cursor_object = $this->newInternalCursorFromExternalCursor($cursor_string);
@@ -196,7 +196,7 @@
return $cursor_object;
}
- final private function getPagingMapFromCursorObject(
+ private function getPagingMapFromCursorObject(
PhabricatorQueryCursor $cursor,
array $keys) {
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
@@ -156,7 +156,7 @@
return $err;
}
- final private function doAdjustSchemata(
+ private function doAdjustSchemata(
PhabricatorStorageManagementAPI $api,
$unsafe) {
@@ -913,7 +913,7 @@
}
}
- final private function doUpgradeSchemata(
+ private function doUpgradeSchemata(
array $apis,
$apply_only,
$no_quickstart,

File Metadata

Mime Type
text/plain
Expires
Sat, May 11, 11:59 PM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6286972
Default Alt Text
D21540.id.diff (6 KB)

Event Timeline