Page MenuHomePhabricator
Files F13184273

D19123.diff
No OneTemporary
Actions

D19123.diff
View Options

diff --git a/src/applications/dashboard/storage/PhabricatorDashboard.php b/src/applications/dashboard/storage/PhabricatorDashboard.php
--- a/src/applications/dashboard/storage/PhabricatorDashboard.php
+++ b/src/applications/dashboard/storage/PhabricatorDashboard.php
@@ -74,7 +74,15 @@
public function setLayoutConfigFromObject(
PhabricatorDashboardLayoutConfig $object) {
+
$this->setLayoutConfig($object->toDictionary());
+
+ // See PHI385. Dashboard panel mutations rely on changes to the Dashboard
+ // object persisting when transactions are applied, but this assumption is
+ // no longer valid after T13054. For now, just save the dashboard
+ // explicitly.
+ $this->save();
+
return $this;
}
diff --git a/src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php b/src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php
--- a/src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php
+++ b/src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php
@@ -34,8 +34,10 @@
$impl = $panel->getImplementation();
if ($impl) {
$type_text = $impl->getPanelTypeName();
+ $icon = $impl->getIcon();
} else {
$type_text = nonempty($panel->getPanelType(), pht('Unknown Type'));
+ $icon = 'fa-question';
}
$id = $panel->getID();
$monogram = $panel->getMonogram();
@@ -44,7 +46,7 @@
$result = id(new PhabricatorTypeaheadResult())
->setName($monogram.' '.$panel->getName())
->setPHID($id)
- ->setIcon($impl->getIcon())
+ ->setIcon($icon)
->addAttribute($type_text);
if (!empty($properties['class'])) {

File Metadata

Mime Type
text/plain
Expires
Sat, May 11, 5:10 PM (1 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6275081
Default Alt Text
D19123.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility