D8168.id18518.diff
No OneTemporary
Actions

Size

25 KB

Referenced Files

None

Subscribers

None

D8168.id18518.diff
View Options

	Index: src/__phutil_library_map__.php
	===================================================================
	--- src/__phutil_library_map__.php
	+++ src/__phutil_library_map__.php
	@@ -1836,7 +1836,6 @@
	'PhabricatorProjectCustomFieldStorage' => 'applications/project/storage/PhabricatorProjectCustomFieldStorage.php',
	'PhabricatorProjectCustomFieldStringIndex' => 'applications/project/storage/PhabricatorProjectCustomFieldStringIndex.php',
	'PhabricatorProjectDAO' => 'applications/project/storage/PhabricatorProjectDAO.php',
	- 'PhabricatorProjectEditor' => 'applications/project/editor/PhabricatorProjectEditor.php',
	'PhabricatorProjectEditorTestCase' => 'applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php',
	'PhabricatorProjectHistoryController' => 'applications/project/controller/PhabricatorProjectHistoryController.php',
	'PhabricatorProjectListController' => 'applications/project/controller/PhabricatorProjectListController.php',
	@@ -4572,7 +4571,6 @@
	'PhabricatorProjectCustomFieldStorage' => 'PhabricatorCustomFieldStorage',
	'PhabricatorProjectCustomFieldStringIndex' => 'PhabricatorCustomFieldStringIndexStorage',
	'PhabricatorProjectDAO' => 'PhabricatorLiskDAO',
	- 'PhabricatorProjectEditor' => 'PhabricatorEditor',
	'PhabricatorProjectEditorTestCase' => 'PhabricatorTestCase',
	'PhabricatorProjectHistoryController' => 'PhabricatorProjectController',
	'PhabricatorProjectListController' =>
	Index: src/applications/project/controller/PhabricatorProjectCreateController.php
	===================================================================
	--- src/applications/project/controller/PhabricatorProjectCreateController.php
	+++ src/applications/project/controller/PhabricatorProjectCreateController.php
	@@ -12,37 +12,33 @@
	$this->requireApplicationCapability(
	ProjectCapabilityCreateProjects::CAPABILITY);

	- $project = new PhabricatorProject();
	- $project->setAuthorPHID($user->getPHID());
	- $project->attachMemberPHIDs(array());
	+ $project = PhabricatorProject::initializeNewProject($user);
	$profile = new PhabricatorProjectProfile();

	$e_name = true;
	$errors = array();
	if ($request->isFormPost()) {
	+ $xactions = array();

	- try {
	- $xactions = array();
	-
	- $xaction = new PhabricatorProjectTransaction();
	- $xaction->setTransactionType(
	- PhabricatorProjectTransaction::TYPE_NAME);
	- $xaction->setNewValue($request->getStr('name'));
	- $xactions[] = $xaction;
	-
	- $xaction = new PhabricatorProjectTransaction();
	- $xaction->setTransactionType(
	- PhabricatorProjectTransaction::TYPE_MEMBERS);
	- $xaction->setNewValue(array($user->getPHID()));
	- $xactions[] = $xaction;
	-
	- $editor = new PhabricatorProjectEditor($project);
	- $editor->setActor($user);
	- $editor->applyTransactions($xactions);
	- } catch (PhabricatorProjectNameCollisionException $ex) {
	- $e_name = 'Not Unique';
	- $errors[] = $ex->getMessage();
	- }
	+ $xactions[] = id(new PhabricatorProjectTransaction())
	+ ->setTransactionType(PhabricatorProjectTransaction::TYPE_NAME)
	+ ->setNewValue($request->getStr('name'));
	+
	+ $xactions[] = id(new PhabricatorProjectTransaction())
	+ ->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
	+ ->setMetadataValue('edge:type', PhabricatorEdgeConfig::TYPE_PROJ_MEMBER)
	+ ->setNewValue(
	+ array(
	+ '+' => array($user->getPHID() => $user->getPHID()),
	+ ));
	+
	+ $editor = id(new PhabricatorProjectTransactionEditor())
	+ ->setActor($user)
	+ ->setContinueOnNoEffect(true)
	+ ->setContentSourceFromRequest($request)
	+ ->applyTransactions($project, $xactions);
	+
	+ // TODO: Deal with name collision exceptions more gracefully.

	$profile->setBlurb($request->getStr('blurb'));

	@@ -103,7 +99,6 @@

	return id(new AphrontDialogResponse())->setDialog($dialog);
	} else {
	-
	$form
	->appendChild(
	id(new AphrontFormSubmitControl())
	Index: src/applications/project/controller/PhabricatorProjectProfileEditController.php
	===================================================================
	--- src/applications/project/controller/PhabricatorProjectProfileEditController.php
	+++ src/applications/project/controller/PhabricatorProjectProfileEditController.php
	@@ -35,45 +35,33 @@

	$errors = array();
	if ($request->isFormPost()) {
	- try {
	- $xactions = array();
	- $xaction = new PhabricatorProjectTransaction();
	- $xaction->setTransactionType(
	- PhabricatorProjectTransaction::TYPE_NAME);
	- $xaction->setNewValue($request->getStr('name'));
	- $xactions[] = $xaction;
	-
	- $xaction = new PhabricatorProjectTransaction();
	- $xaction->setTransactionType(
	- PhabricatorProjectTransaction::TYPE_STATUS);
	- $xaction->setNewValue($request->getStr('status'));
	- $xactions[] = $xaction;
	-
	- $xaction = new PhabricatorProjectTransaction();
	- $xaction->setTransactionType(
	- PhabricatorTransactions::TYPE_VIEW_POLICY);
	- $xaction->setNewValue($request->getStr('can_view'));
	- $xactions[] = $xaction;
	-
	- $xaction = new PhabricatorProjectTransaction();
	- $xaction->setTransactionType(
	- PhabricatorTransactions::TYPE_EDIT_POLICY);
	- $xaction->setNewValue($request->getStr('can_edit'));
	- $xactions[] = $xaction;
	-
	- $xaction = new PhabricatorProjectTransaction();
	- $xaction->setTransactionType(
	- PhabricatorTransactions::TYPE_JOIN_POLICY);
	- $xaction->setNewValue($request->getStr('can_join'));
	- $xactions[] = $xaction;
	-
	- $editor = new PhabricatorProjectEditor($project);
	- $editor->setActor($user);
	- $editor->applyTransactions($xactions);
	- } catch (PhabricatorProjectNameCollisionException $ex) {
	- $e_name = pht('Not Unique');
	- $errors[] = $ex->getMessage();
	- }
	+ $xactions = array();
	+
	+ $xactions[] = id(new PhabricatorProjectTransaction())
	+ ->setTransactionType(PhabricatorProjectTransaction::TYPE_NAME)
	+ ->setNewValue($request->getStr('name'));
	+
	+ $xactions[] = id(new PhabricatorProjectTransaction())
	+ ->setTransactionType(PhabricatorProjectTransaction::TYPE_STATUS)
	+ ->setNewValue($request->getStr('status'));
	+
	+ $xactions[] = id(new PhabricatorProjectTransaction())
	+ ->setTransactionType(PhabricatorTransactions::TYPE_VIEW_POLICY)
	+ ->setNewValue($request->getStr('can_view'));
	+
	+ $xactions[] = id(new PhabricatorProjectTransaction())
	+ ->setTransactionType(PhabricatorTransactions::TYPE_EDIT_POLICY)
	+ ->setNewValue($request->getStr('can_edit'));
	+
	+ $xactions[] = id(new PhabricatorProjectTransaction())
	+ ->setTransactionType(PhabricatorTransactions::TYPE_JOIN_POLICY)
	+ ->setNewValue($request->getStr('can_join'));
	+
	+ $editor = id(new PhabricatorProjectTransactionEditor())
	+ ->setActor($user)
	+ ->setContentSourceFromRequest($request)
	+ ->setContinueOnNoEffect(true)
	+ ->applyTransactions($project, $xactions);

	$profile->setBlurb($request->getStr('blurb'));

	Index: src/applications/project/editor/PhabricatorProjectEditor.php
	===================================================================
	--- src/applications/project/editor/PhabricatorProjectEditor.php
	+++ /dev/null
	@@ -1,255 +0,0 @@
	-<?php
	-
	-final class PhabricatorProjectEditor extends PhabricatorEditor {
	-
	- private $project;
	- private $projectName;
	-
	- private $addEdges = array();
	- private $remEdges = array();
	-
	- private $shouldArchive = false;
	-
	- private function setShouldArchive($should_archive) {
	- $this->shouldArchive = $should_archive;
	- return $this;
	- }
	- private function shouldArchive() {
	- return $this->shouldArchive;
	- }
	-
	- public function __construct(PhabricatorProject $project) {
	- $this->project = $project;
	- }
	-
	- public function applyTransactions(array $transactions) {
	- assert_instances_of($transactions, 'PhabricatorProjectTransaction');
	- $actor = $this->requireActor();
	-
	- $project = $this->project;
	-
	- $is_new = !$project->getID();
	-
	- if ($is_new) {
	- $project->setAuthorPHID($actor->getPHID());
	- }
	-
	- foreach ($transactions as $key => $xaction) {
	- $this->setTransactionOldValue($project, $xaction);
	- if (!$this->transactionHasEffect($xaction)) {
	- unset($transactions[$key]);
	- continue;
	- }
	- }
	-
	- if (!$is_new) {
	- // You must be able to view a project in order to edit it in any capacity.
	- PhabricatorPolicyFilter::requireCapability(
	- $actor,
	- $project,
	- PhabricatorPolicyCapability::CAN_VIEW);
	-
	- PhabricatorPolicyFilter::requireCapability(
	- $actor,
	- $project,
	- PhabricatorPolicyCapability::CAN_EDIT);
	- }
	-
	- if (!$transactions) {
	- return $this;
	- }
	-
	- foreach ($transactions as $xaction) {
	- $this->applyTransactionEffect($project, $xaction);
	- }
	-
	- try {
	- $project->openTransaction();
	-
	- if ($this->shouldArchive()) {
	- $project->setStatus(PhabricatorProjectStatus::STATUS_ARCHIVED);
	- }
	- $project->save();
	-
	- $edge_type = PhabricatorEdgeConfig::TYPE_PROJ_MEMBER;
	- $editor = new PhabricatorEdgeEditor();
	- $editor->setActor($actor);
	- foreach ($this->remEdges as $phid) {
	- $editor->removeEdge($project->getPHID(), $edge_type, $phid);
	- }
	- foreach ($this->addEdges as $phid) {
	- $editor->addEdge($project->getPHID(), $edge_type, $phid);
	- }
	- $editor->save();
	-
	- foreach ($transactions as $xaction) {
	- $xaction->setAuthorPHID($actor->getPHID());
	- $xaction->setObjectPHID($project->getPHID());
	- $xaction->setViewPolicy('public');
	- $xaction->setEditPolicy($actor->getPHID());
	- $xaction->setContentSource(
	- PhabricatorContentSource::newForSource(
	- PhabricatorContentSource::SOURCE_LEGACY,
	- array()));
	- $xaction->save();
	- }
	- $project->saveTransaction();
	- } catch (AphrontQueryDuplicateKeyException $ex) {
	- // We already validated the slug, but might race. Try again to see if
	- // that's the issue. If it is, we'll throw a more specific exception. If
	- // not, throw the original exception.
	- $this->validateName($project);
	- throw $ex;
	- }
	-
	- id(new PhabricatorSearchIndexer())
	- ->queueDocumentForIndexing($project->getPHID());
	-
	- return $this;
	- }
	-
	- private function validateName(PhabricatorProject $project) {
	- $slug = $project->getPhrictionSlug();
	- $name = $project->getName();
	-
	- if ($slug == '/') {
	- throw new PhabricatorProjectNameCollisionException(
	- pht("Project names must be unique and contain some ".
	- "letters or numbers."));
	- }
	-
	- $id = $project->getID();
	- $collision = id(new PhabricatorProject())->loadOneWhere(
	- '(name = %s OR phrictionSlug = %s) AND id %Q %nd',
	- $name,
	- $slug,
	- $id ? '!=' : 'IS NOT',
	- $id ? $id : null);
	-
	- if ($collision) {
	- $other_name = $collision->getName();
	- $other_id = $collision->getID();
	- throw new PhabricatorProjectNameCollisionException(
	- pht("Project names must be unique. The name '%s' is too similar to ".
	- "the name of another project, '%s' (Project ID: ".
	- "%d). Choose a unique name.", $name, $other_name, $other_id));
	- }
	- }
	-
	- private function setTransactionOldValue(
	- PhabricatorProject $project,
	- PhabricatorProjectTransaction $xaction) {
	-
	- $type = $xaction->getTransactionType();
	- switch ($type) {
	- case PhabricatorProjectTransaction::TYPE_NAME:
	- $xaction->setOldValue($project->getName());
	- break;
	- case PhabricatorProjectTransaction::TYPE_STATUS:
	- $xaction->setOldValue($project->getStatus());
	- break;
	- case PhabricatorProjectTransaction::TYPE_MEMBERS:
	- $member_phids = $project->getMemberPHIDs();
	-
	- $old_value = array_values($member_phids);
	- $xaction->setOldValue($old_value);
	-
	- $new_value = $xaction->getNewValue();
	- $new_value = array_filter($new_value);
	- $new_value = array_unique($new_value);
	- $new_value = array_values($new_value);
	- $xaction->setNewValue($new_value);
	- break;
	- case PhabricatorTransactions::TYPE_VIEW_POLICY:
	- $xaction->setOldValue($project->getViewPolicy());
	- break;
	- case PhabricatorTransactions::TYPE_EDIT_POLICY:
	- $xaction->setOldValue($project->getEditPolicy());
	- break;
	- case PhabricatorTransactions::TYPE_JOIN_POLICY:
	- $xaction->setOldValue($project->getJoinPolicy());
	- break;
	- default:
	- throw new Exception("Unknown transaction type '{$type}'!");
	- }
	- return $this;
	- }
	-
	- private function applyTransactionEffect(
	- PhabricatorProject $project,
	- PhabricatorProjectTransaction $xaction) {
	-
	- $type = $xaction->getTransactionType();
	- switch ($type) {
	- case PhabricatorProjectTransaction::TYPE_NAME:
	- $old_slug = $project->getFullPhrictionSlug();
	- $project->setName($xaction->getNewValue());
	- $project->setPhrictionSlug($xaction->getNewValue());
	- $changed_slug = $old_slug != $project->getFullPhrictionSlug();
	- if ($xaction->getOldValue() && $changed_slug) {
	- $old_document = id(new PhrictionDocument())
	- ->loadOneWhere(
	- 'slug = %s',
	- $old_slug);
	- if ($old_document && $old_document->getStatus() ==
	- PhrictionDocumentStatus::STATUS_EXISTS) {
	- $content = id(new PhrictionContent())
	- ->load($old_document->getContentID());
	- $from_editor = id(PhrictionDocumentEditor::newForSlug($old_slug))
	- ->setActor($this->getActor())
	- ->setTitle($content->getTitle())
	- ->setContent($content->getContent())
	- ->setDescription($content->getDescription());
	-
	- $target_editor = id(PhrictionDocumentEditor::newForSlug(
	- $project->getFullPhrictionSlug()))
	- ->setActor($this->getActor())
	- ->setTitle($content->getTitle())
	- ->setContent($content->getContent())
	- ->setDescription($content->getDescription())
	- ->moveHere($old_document->getID(), $old_document->getPHID());
	-
	- $target_document = $target_editor->getDocument();
	- $from_editor->moveAway($target_document->getID());
	- }
	- }
	- $this->validateName($project);
	- break;
	- case PhabricatorProjectTransaction::TYPE_STATUS:
	- $project->setStatus($xaction->getNewValue());
	- break;
	- case PhabricatorProjectTransaction::TYPE_MEMBERS:
	- $old = array_fill_keys($xaction->getOldValue(), true);
	- $new = array_fill_keys($xaction->getNewValue(), true);
	- $this->addEdges = array_keys(array_diff_key($new, $old));
	- $this->remEdges = array_keys(array_diff_key($old, $new));
	- if ($new === array()) {
	- $this->setShouldArchive(true);
	- }
	- break;
	- case PhabricatorTransactions::TYPE_VIEW_POLICY:
	- $project->setViewPolicy($xaction->getNewValue());
	- break;
	- case PhabricatorTransactions::TYPE_EDIT_POLICY:
	- $project->setEditPolicy($xaction->getNewValue());
	-
	- // You can't edit away your ability to edit the project.
	- PhabricatorPolicyFilter::mustRetainCapability(
	- $this->getActor(),
	- $project,
	- PhabricatorPolicyCapability::CAN_EDIT);
	- break;
	- case PhabricatorTransactions::TYPE_JOIN_POLICY:
	- $project->setJoinPolicy($xaction->getNewValue());
	- break;
	- default:
	- throw new Exception("Unknown transaction type '{$type}'!");
	- }
	- }
	-
	- private function transactionHasEffect(
	- PhabricatorProjectTransaction $xaction) {
	- return ($xaction->getOldValue() !== $xaction->getNewValue());
	- }
	-
	-}
	Index: src/applications/project/editor/PhabricatorProjectTransactionEditor.php
	===================================================================
	--- src/applications/project/editor/PhabricatorProjectTransactionEditor.php
	+++ src/applications/project/editor/PhabricatorProjectTransactionEditor.php
	@@ -7,6 +7,12 @@
	$types = parent::getTransactionTypes();

	$types[] = PhabricatorTransactions::TYPE_EDGE;
	+ $types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
	+ $types[] = PhabricatorTransactions::TYPE_EDIT_POLICY;
	+ $types[] = PhabricatorTransactions::TYPE_JOIN_POLICY;
	+
	+ $types[] = PhabricatorProjectTransaction::TYPE_NAME;
	+ $types[] = PhabricatorProjectTransaction::TYPE_STATUS;

	return $types;
	}
	@@ -16,6 +22,10 @@
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	+ case PhabricatorProjectTransaction::TYPE_NAME:
	+ return $object->getName();
	+ case PhabricatorProjectTransaction::TYPE_STATUS:
	+ return $object->getStatus();
	}

	return parent::getCustomTransactionOldValue($object, $xaction);
	@@ -26,6 +36,9 @@
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	+ case PhabricatorProjectTransaction::TYPE_NAME:
	+ case PhabricatorProjectTransaction::TYPE_STATUS:
	+ return $xaction->getNewValue();
	}

	return parent::getCustomTransactionNewValue($object, $xaction);
	@@ -36,8 +49,23 @@
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	+ case PhabricatorProjectTransaction::TYPE_NAME:
	+ $object->setName($xaction->getNewValue());
	+ return;
	+ case PhabricatorProjectTransaction::TYPE_STATUS:
	+ $object->setStatus($xaction->getNewValue());
	+ return;
	case PhabricatorTransactions::TYPE_EDGE:
	return;
	+ case PhabricatorTransactions::TYPE_VIEW_POLICY:
	+ $object->setViewPolicy($xaction->getNewValue());
	+ return;
	+ case PhabricatorTransactions::TYPE_EDIT_POLICY:
	+ $object->setEditPolicy($xaction->getNewValue());
	+ return;
	+ case PhabricatorTransactions::TYPE_JOIN_POLICY:
	+ $object->setJoinPolicy($xaction->getNewValue());
	+ return;
	}

	return parent::applyCustomInternalTransaction($object, $xaction);
	@@ -48,7 +76,43 @@
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	+ case PhabricatorProjectTransaction::TYPE_NAME:
	+ $old_slug = $object->getFullPhrictionSlug();
	+ $object->setPhrictionSlug($xaction->getNewValue());
	+ $changed_slug = $old_slug != $object->getFullPhrictionSlug();
	+ if ($xaction->getOldValue() && $changed_slug) {
	+ $old_document = id(new PhrictionDocument())
	+ ->loadOneWhere(
	+ 'slug = %s',
	+ $old_slug);
	+ if ($old_document && $old_document->getStatus() ==
	+ PhrictionDocumentStatus::STATUS_EXISTS) {
	+ $content = id(new PhrictionContent())
	+ ->load($old_document->getContentID());
	+ $from_editor = id(PhrictionDocumentEditor::newForSlug($old_slug))
	+ ->setActor($this->getActor())
	+ ->setTitle($content->getTitle())
	+ ->setContent($content->getContent())
	+ ->setDescription($content->getDescription());
	+
	+ $target_editor = id(PhrictionDocumentEditor::newForSlug(
	+ $object->getFullPhrictionSlug()))
	+ ->setActor($this->getActor())
	+ ->setTitle($content->getTitle())
	+ ->setContent($content->getContent())
	+ ->setDescription($content->getDescription())
	+ ->moveHere($old_document->getID(), $old_document->getPHID());
	+
	+ $target_document = $target_editor->getDocument();
	+ $from_editor->moveAway($target_document->getID());
	+ }
	+ }
	+ return;
	+ case PhabricatorTransactions::TYPE_VIEW_POLICY:
	+ case PhabricatorTransactions::TYPE_EDIT_POLICY:
	+ case PhabricatorTransactions::TYPE_JOIN_POLICY:
	case PhabricatorTransactions::TYPE_EDGE:
	+ case PhabricatorProjectTransaction::TYPE_STATUS:
	return;
	}

	@@ -63,16 +127,40 @@
	$errors = parent::validateTransaction($object, $type, $xactions);

	switch ($type) {
	+ case PhabricatorProjectTransaction::TYPE_NAME:
	+ $missing = $this->validateIsEmptyTextField(
	+ $object->getName(),
	+ $xactions);
	+
	+ if ($missing) {
	+ $error = new PhabricatorApplicationTransactionValidationError(
	+ $type,
	+ pht('Required'),
	+ pht('Project name is required.'),
	+ nonempty(last($xactions), null));
	+
	+ $error->setIsMissingFieldError(true);
	+ $errors[] = $error;
	+ }
	+ break;
	}

	return $errors;
	}

	+
	protected function requireCapabilities(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	+ case PhabricatorProjectTransaction::TYPE_NAME:
	+ case PhabricatorProjectTransaction::TYPE_STATUS:
	+ PhabricatorPolicyFilter::requireCapability(
	+ $this->requireActor(),
	+ $object,
	+ PhabricatorPolicyCapability::CAN_EDIT);
	+ return;
	case PhabricatorTransactions::TYPE_EDGE:
	switch ($xaction->getMetadataValue('edge:type')) {
	case PhabricatorEdgeConfig::TYPE_PROJ_MEMBER:
	@@ -107,7 +195,11 @@
	break;
	}

	- return parent::requireCapabilities();
	+ return parent::requireCapabilities($object, $xaction);
	+ }
	+
	+ protected function supportsSearch() {
	+ return true;
	}

	}
	Index: src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php
	===================================================================
	--- src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php
	+++ src/applications/project/editor/__tests__/PhabricatorProjectEditorTestCase.php
	@@ -97,9 +97,10 @@
	$xaction->setTransactionType(PhabricatorProjectTransaction::TYPE_NAME);
	$xaction->setNewValue($new_name);

	- $editor = new PhabricatorProjectEditor($proj);
	+ $editor = new PhabricatorProjectTransactionEditor();
	$editor->setActor($user);
	- $editor->applyTransactions(array($xaction));
	+ $editor->setContentSource(PhabricatorContentSource::newConsoleSource());
	+ $editor->applyTransactions($proj, array($xaction));

	return true;
	}
	Index: src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php
	===================================================================
	--- src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php
	+++ src/applications/project/lipsum/PhabricatorProjectTestDataGenerator.php
	@@ -32,9 +32,10 @@
	PhabricatorTransactions::TYPE_JOIN_POLICY,
	PhabricatorPolicies::POLICY_PUBLIC);

	- $editor = id(new PhabricatorProjectEditor($project))
	+ $editor = id(new PhabricatorProjectTransactionEditor())
	->setActor($author)
	- ->applyTransactions($this->xactions);
	+ ->setContentSource(PhabricatorContentSource::newConsoleSource())
	+ ->applyTransactions($project, $this->xactions);

	$profile = id(new PhabricatorProjectProfile())
	->setBlurb($this->generateDescription())
	Index: src/applications/project/storage/PhabricatorProject.php
	===================================================================
	--- src/applications/project/storage/PhabricatorProject.php
	+++ src/applications/project/storage/PhabricatorProject.php
	@@ -20,6 +20,16 @@
	private $sparseMembers = self::ATTACHABLE;
	private $profile = self::ATTACHABLE;

	+ public static function initializeNewProject(PhabricatorUser $actor) {
	+ return id(new PhabricatorProject())
	+ ->setName('')
	+ ->setAuthorPHID($actor->getPHID())
	+ ->setViewPolicy(PhabricatorPolicies::POLICY_USER)
	+ ->setEditPolicy(PhabricatorPolicies::POLICY_USER)
	+ ->setJoinPolicy(PhabricatorPolicies::POLICY_USER)
	+ ->attachMemberPHIDs(array());
	+ }
	+
	public function getCapabilities() {
	return array(
	PhabricatorPolicyCapability::CAN_VIEW,
	@@ -73,6 +83,9 @@
	}

	public function isUserMember($user_phid) {
	+ if ($this->memberPHIDs !== self::ATTACHABLE) {
	+ return in_array($user_phid, $this->memberPHIDs);
	+ }
	return $this->assertAttachedKey($this->sparseMembers, $user_phid);
	}

	Index: src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	===================================================================
	--- src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	+++ src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	@@ -139,6 +139,8 @@
	return $object->getViewPolicy();
	case PhabricatorTransactions::TYPE_EDIT_POLICY:
	return $object->getEditPolicy();
	+ case PhabricatorTransactions::TYPE_JOIN_POLICY:
	+ return $object->getJoinPolicy();
	case PhabricatorTransactions::TYPE_EDGE:
	$edge_type = $xaction->getMetadataValue('edge:type');
	if (!$edge_type) {
	@@ -175,6 +177,7 @@
	return $this->getPHIDTransactionNewValue($xaction);
	case PhabricatorTransactions::TYPE_VIEW_POLICY:
	case PhabricatorTransactions::TYPE_EDIT_POLICY:
	+ case PhabricatorTransactions::TYPE_JOIN_POLICY:
	return $xaction->getNewValue();
	case PhabricatorTransactions::TYPE_EDGE:
	return $this->getEdgeTransactionNewValue($xaction);

File Metadata

Mime Type: text/plain
Expires: May 11 2024, 10:34 AM (5 w, 8 h ago)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 6276907
Default Alt Text: D8168.id18518.diff (25 KB)

D8168.id18518.diffNo OneTemporaryActions

D8168.id18518.diffView Options

File Metadata

Event Timeline

D8168.id18518.diff
No OneTemporary
Actions

D8168.id18518.diff
View Options