Page MenuHomePhabricator
Files F13182673

D20876.id49769.diff
No OneTemporary
Actions

D20876.id49769.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -12,7 +12,7 @@
'core.pkg.css' => '686ae87c',
'core.pkg.js' => '6e5c894f',
'differential.pkg.css' => '607c84be',
- 'differential.pkg.js' => 'a0212a0b',
+ 'differential.pkg.js' => '1b97518d',
'diffusion.pkg.css' => '42c75c37',
'diffusion.pkg.js' => 'a98c0bf7',
'maniphest.pkg.css' => '35995d6d',
@@ -428,7 +428,7 @@
'rsrc/js/application/releeph/releeph-preview-branch.js' => '75184d68',
'rsrc/js/application/releeph/releeph-request-state-change.js' => '9f081f05',
'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'aa3a100c',
- 'rsrc/js/application/repository/repository-crossreference.js' => 'c15122b4',
+ 'rsrc/js/application/repository/repository-crossreference.js' => '1c95ea63',
'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e5bdb730',
'rsrc/js/application/search/behavior-reorder-queries.js' => 'b86f297f',
'rsrc/js/application/transactions/behavior-comment-actions.js' => '4dffaeb2',
@@ -682,7 +682,7 @@
'javelin-behavior-reorder-applications' => 'aa371860',
'javelin-behavior-reorder-columns' => '8ac32fd9',
'javelin-behavior-reorder-profile-menu-items' => 'e5bdb730',
- 'javelin-behavior-repository-crossreference' => 'c15122b4',
+ 'javelin-behavior-repository-crossreference' => '1c95ea63',
'javelin-behavior-scrollbar' => '92388bae',
'javelin-behavior-search-reorder-queries' => 'b86f297f',
'javelin-behavior-select-content' => 'e8240b50',
@@ -1034,6 +1034,12 @@
'javelin-install',
'javelin-util',
),
+ '1c95ea63' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-stratcom',
+ 'javelin-uri',
+ ),
'1cab0e9a' => array(
'javelin-behavior',
'javelin-dom',
@@ -1977,12 +1983,6 @@
'c03f2fb4' => array(
'javelin-install',
),
- 'c15122b4' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-stratcom',
- 'javelin-uri',
- ),
'c2c500a7' => array(
'javelin-install',
'javelin-dom',
diff --git a/webroot/rsrc/js/application/repository/repository-crossreference.js b/webroot/rsrc/js/application/repository/repository-crossreference.js
--- a/webroot/rsrc/js/application/repository/repository-crossreference.js
+++ b/webroot/rsrc/js/application/repository/repository-crossreference.js
@@ -152,7 +152,16 @@
query.char = char;
}
- var uri = JX.$U('/diffusion/symbol/' + symbol + '/');
+ var uri_symbol = symbol;
+
+ // In some cases, lexers may include whitespace in symbol tags. Trim it,
+ // since symbols with semantic whitespace aren't supported.
+ uri_symbol = uri_symbol.trim();
+
+ // See T13437. Symbols like "#define" need to be encoded.
+ uri_symbol = encodeURIComponent(uri_symbol);
+
+ var uri = JX.$U('/diffusion/symbol/' + uri_symbol + '/');
uri.addQueryParams(query);
window.open(uri.toString());

File Metadata

Mime Type
text/plain
Expires
Sat, May 11, 12:58 AM (1 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6277829
Default Alt Text
D20876.id49769.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility