Page MenuHomePhabricator

D11160.diff
No OneTemporary

D11160.diff

diff --git a/src/internationalization/PhutilTranslator.php b/src/internationalization/PhutilTranslator.php
--- a/src/internationalization/PhutilTranslator.php
+++ b/src/internationalization/PhutilTranslator.php
@@ -89,6 +89,13 @@
}
$result = vsprintf($translation, $args);
+ if ($result === false) {
+ // If vsprintf() fails (often because the translated string references
+ // too many parameters), show the bad template with a note instead of
+ // returning an empty string. This makes it easier to figure out what
+ // went wrong and fix it.
+ $result = '[Invalid Translation!] '.$translation;
+ }
if ($this->language == 'en-ac') {
$result = strtoupper($result);

File Metadata

Mime Type
text/plain
Expires
Fri, May 10, 11:52 AM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6282051
Default Alt Text
D11160.diff (724 B)

Event Timeline