Page MenuHomePhabricator

D15006.id36248.diff
No OneTemporary

D15006.id36248.diff

diff --git a/src/applications/project/remarkup/ProjectRemarkupRule.php b/src/applications/project/remarkup/ProjectRemarkupRule.php
--- a/src/applications/project/remarkup/ProjectRemarkupRule.php
+++ b/src/applications/project/remarkup/ProjectRemarkupRule.php
@@ -19,6 +19,10 @@
return $handle->renderTag();
}
+ protected function shouldMarkupObject(array $params) {
+ return true;
+ }
+
protected function getObjectIDPattern() {
// NOTE: The latter half of this rule matches monograms with internal
// periods, like `#domain.com`, but does not match monograms with terminal
@@ -32,7 +36,7 @@
// controlling and these names should parse correctly.
// These characters may never appear anywhere in a hashtag.
- $never = '\s?!,:;{}#\\(\\)"\'';
+ $never = '\s?!,:;{}#\\(\\)"\'\\*/~';
// These characters may not appear at the edge of the string.
$never_edge = '.';
diff --git a/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php b/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
--- a/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
+++ b/src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php
@@ -125,6 +125,16 @@
),
),
+ '**#orbital**' => array(
+ 'embed' => array(),
+ 'ref' => array(
+ array(
+ 'offset' => 3,
+ 'id' => 'orbital',
+ ),
+ ),
+ ),
+
);
foreach ($cases as $input => $expect) {

File Metadata

Mime Type
text/plain
Expires
Fri, May 10, 12:24 AM (3 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6280899
Default Alt Text
D15006.id36248.diff (1 KB)

Event Timeline