Page MenuHomePhabricator
Files F13180439

D12420.diff
No OneTemporary
Actions

D12420.diff
View Options

diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
--- a/src/lint/linter/ArcanistXHPASTLinter.php
+++ b/src/lint/linter/ArcanistXHPASTLinter.php
@@ -63,6 +63,7 @@
const LINT_LOWERCASE_FUNCTIONS = 61;
const LINT_CLASS_NAME_LITERAL = 62;
const LINT_USELESS_OVERRIDING_METHOD = 63;
+ const LINT_NO_PARENT_SCOPE = 64;
private $blacklistedFunctions = array();
private $naminghook;
@@ -197,6 +198,8 @@
=> pht('Class Name Literal'),
self::LINT_USELESS_OVERRIDING_METHOD
=> pht('Useless Overriding Method'),
+ self::LINT_NO_PARENT_SCOPE
+ => pht('No Parent Scope'),
);
}
@@ -405,6 +408,7 @@
'lintLowercaseFunctions' => self::LINT_LOWERCASE_FUNCTIONS,
'lintClassNameLiteral' => self::LINT_CLASS_NAME_LITERAL,
'lintUselessOverridingMethods' => self::LINT_USELESS_OVERRIDING_METHOD,
+ 'lintNoParentScope' => self::LINT_NO_PARENT_SCOPE,
);
foreach ($method_codes as $method => $codes) {
@@ -3849,6 +3853,36 @@
}
}
+ private function lintNoParentScope(XHPASTNode $root) {
+ $classes = $root->selectDescendantsOfType('n_CLASS_DECLARATION');
+
+ foreach ($classes as $class) {
+ $methods = $class->selectDescendantsOfType('n_METHOD_DECLARATION');
+
+ if ($class->getChildByIndex(2)->getTypeName() == 'n_EXTENDS_LIST') {
+ continue;
+ }
+
+ foreach ($methods as $method) {
+ $static_accesses = $method
+ ->selectDescendantsOfType('n_CLASS_STATIC_ACCESS');
+
+ foreach ($static_accesses as $static_access) {
+ $called_class = $static_access->getChildOfType(0, 'n_CLASS_NAME');
+
+ if ($called_class->getConcreteString() == 'parent') {
+ $this->raiseLintAtNode(
+ $static_access,
+ self::LINT_NO_PARENT_SCOPE,
+ pht(
+ 'Cannot access %s when current class scope has no parent.',
+ 'parent::'));
+ }
+ }
+ }
+ }
+ }
+
/**
* Retrieve all calls to some specified function(s).
diff --git a/src/lint/linter/__tests__/xhpast/no-parent-scope.lint-test b/src/lint/linter/__tests__/xhpast/no-parent-scope.lint-test
new file mode 100644
--- /dev/null
+++ b/src/lint/linter/__tests__/xhpast/no-parent-scope.lint-test
@@ -0,0 +1,15 @@
+<?php
+
+final class MyValidClass extends SomeOtherClass {
+ public function __construct() {
+ parent::__construct(null);
+ }
+}
+
+final class MyInvalidClass {
+ public function __construct() {
+ parent::__construct(null);
+ }
+}
+~~~~~~~~~~
+error:11:5

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 11:56 PM (3 w, 11 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6280748
Default Alt Text
D12420.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility