Page MenuHomePhabricator
Files F13179242

D14189.diff
No OneTemporary
Actions

D14189.diff
View Options

diff --git a/src/applications/owners/controller/PhabricatorOwnersDetailController.php b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
--- a/src/applications/owners/controller/PhabricatorOwnersDetailController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
@@ -76,27 +76,28 @@
'auditorPHIDs' => $package->getPHID(),
));
+ $status_concern = DiffusionCommitQuery::AUDIT_STATUS_CONCERN;
+
$attention_commits = id(new DiffusionCommitQuery())
->setViewer($request->getUser())
->withAuditorPHIDs(array($package->getPHID()))
- ->withAuditStatus(DiffusionCommitQuery::AUDIT_STATUS_CONCERN)
+ ->withAuditStatus($status_concern)
->needCommitData(true)
->setLimit(10)
->execute();
- if ($attention_commits) {
- $view = id(new PhabricatorAuditListView())
- ->setUser($viewer)
- ->setCommits($attention_commits);
-
- $commit_views[] = array(
- 'view' => $view,
- 'header' => pht('Commits in this Package that Need Attention'),
- 'button' => id(new PHUIButtonView())
- ->setTag('a')
- ->setHref($commit_uri->alter('status', 'open'))
- ->setText(pht('View All Problem Commits')),
- );
- }
+ $view = id(new PhabricatorAuditListView())
+ ->setUser($viewer)
+ ->setNoDataString(pht('This package has no open problem commits.'))
+ ->setCommits($attention_commits);
+
+ $commit_views[] = array(
+ 'view' => $view,
+ 'header' => pht('Commits in this Package that Need Attention'),
+ 'button' => id(new PHUIButtonView())
+ ->setTag('a')
+ ->setHref($commit_uri->alter('status', $status_concern))
+ ->setText(pht('View All Problem Commits')),
+ );
$all_commits = id(new DiffusionCommitQuery())
->setViewer($request->getUser())

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 9:03 PM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6277485
Default Alt Text
D14189.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility