Differential D14189

Fix button for "All Problem Commits" on Owners packages
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 1:40 PM.

Details

Reviewers

chad

Maniphest Tasks

T9482: Problems in the "Commits in this Package that Need Attention" view

Commits

Restricted Diffusion Commit
rPbe83d62375b0: Fix button for "All Problem Commits" on Owners packages

Summary

Ref T9482. This button goes to the wrong place and this table conditionally hides itself so I missed it.

Instead:

Always show the table, with an empty string if there are no relevant commits.
Link to a working UI.

Test Plan

Saw table. Clicked button.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34275.Sep 29 2015, 1:40 PM

epriestley retitled this revision from to Fix button for "All Problem Commits" on Owners packages.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9482: Problems in the "Commits in this Package that Need Attention" view.

chad accepted this revision.Sep 29 2015, 1:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2015, 1:41 PM

epriestley mentioned this in T9482: Problems in the "Commits in this Package that Need Attention" view.Sep 29 2015, 1:43 PM

Closed by commit rPbe83d62375b0: Fix button for "All Problem Commits" on Owners packages (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

owners/

controller/

PhabricatorOwnersDetailController.php

31 lines

Diff 34277

View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Fix button for "All Problem Commits" on Owners packagesClosedPublicActions