Page MenuHomePhabricator
Files F13178677

D18973.diff
No OneTemporary
Actions

D18973.diff
View Options

diff --git a/src/applications/diffusion/controller/DiffusionPullLogListController.php b/src/applications/diffusion/controller/DiffusionPullLogListController.php
--- a/src/applications/diffusion/controller/DiffusionPullLogListController.php
+++ b/src/applications/diffusion/controller/DiffusionPullLogListController.php
@@ -9,4 +9,9 @@
->buildResponse();
}
+ protected function buildApplicationCrumbs() {
+ return parent::buildApplicationCrumbs()
+ ->addTextCrumb(pht('Pull Logs'), $this->getApplicationURI('pulllog/'));
+ }
+
}
diff --git a/src/applications/diffusion/controller/DiffusionPushLogListController.php b/src/applications/diffusion/controller/DiffusionPushLogListController.php
--- a/src/applications/diffusion/controller/DiffusionPushLogListController.php
+++ b/src/applications/diffusion/controller/DiffusionPushLogListController.php
@@ -9,4 +9,9 @@
->buildResponse();
}
+ protected function buildApplicationCrumbs() {
+ return parent::buildApplicationCrumbs()
+ ->addTextCrumb(pht('Push Logs'), $this->getApplicationURI('pushlog/'));
+ }
+
}
diff --git a/src/applications/diffusion/view/DiffusionPushLogListView.php b/src/applications/diffusion/view/DiffusionPushLogListView.php
--- a/src/applications/diffusion/view/DiffusionPushLogListView.php
+++ b/src/applications/diffusion/view/DiffusionPushLogListView.php
@@ -28,6 +28,9 @@
// Only administrators can view remote addresses.
$remotes_visible = $viewer->getIsAdmin();
+ $flag_map = PhabricatorRepositoryPushLog::getFlagDisplayNames();
+ $reject_map = PhabricatorRepositoryPushLog::getRejectCodeDisplayNames();
+
$rows = array();
$any_host = false;
foreach ($logs as $log) {
@@ -59,6 +62,23 @@
$device = null;
}
+ $flags = $log->getChangeFlags();
+ $flag_names = array();
+ foreach ($flag_map as $flag_key => $flag_name) {
+ if (($flags & $flag_key) === $flag_key) {
+ $flag_names[] = $flag_name;
+ }
+ }
+ $flag_names = phutil_implode_html(
+ phutil_tag('br'),
+ $flag_names);
+
+ $reject_code = $log->getPushEvent()->getRejectCode();
+ $reject_label = idx(
+ $reject_map,
+ $reject_code,
+ pht('Unknown ("%s")', $reject_code));
+
$rows[] = array(
phutil_tag(
'a',
@@ -85,10 +105,8 @@
'href' => $repository->getCommitURI($log->getRefNew()),
),
$log->getRefNewShort()),
-
- // TODO: Make these human-readable.
- $log->getChangeFlags(),
- $log->getPushEvent()->getRejectCode(),
+ $flag_names,
+ $reject_label,
$viewer->formatShortDateTime($log->getEpoch()),
);
}
@@ -107,7 +125,7 @@
pht('Old'),
pht('New'),
pht('Flags'),
- pht('Code'),
+ pht('Result'),
pht('Date'),
))
->setColumnClasses(
@@ -122,6 +140,8 @@
'wide',
'n',
'n',
+ '',
+ '',
'right',
))
->setColumnVisibility(

File Metadata

Mime Type
text/plain
Expires
May 9 2024, 8:35 PM (5 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6274038
Default Alt Text
D18973.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility