Page MenuHomePhabricator

D12734.diff
No OneTemporary

D12734.diff

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -2388,7 +2388,6 @@
'PhabricatorRemarkupFigletBlockInterpreter' => 'infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php',
'PhabricatorRemarkupGraphvizBlockInterpreter' => 'infrastructure/markup/interpreter/PhabricatorRemarkupGraphvizBlockInterpreter.php',
'PhabricatorRemarkupUIExample' => 'applications/uiexample/examples/PhabricatorRemarkupUIExample.php',
- 'PhabricatorRepositoriesApplication' => 'applications/repository/application/PhabricatorRepositoriesApplication.php',
'PhabricatorRepositoriesSetupCheck' => 'applications/config/check/PhabricatorRepositoriesSetupCheck.php',
'PhabricatorRepository' => 'applications/repository/storage/PhabricatorRepository.php',
'PhabricatorRepositoryArcanistProject' => 'applications/repository/storage/PhabricatorRepositoryArcanistProject.php',
@@ -2407,7 +2406,6 @@
'PhabricatorRepositoryCommitRef' => 'applications/repository/engine/PhabricatorRepositoryCommitRef.php',
'PhabricatorRepositoryCommitSearchIndexer' => 'applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php',
'PhabricatorRepositoryConfigOptions' => 'applications/repository/config/PhabricatorRepositoryConfigOptions.php',
- 'PhabricatorRepositoryController' => 'applications/repository/controller/PhabricatorRepositoryController.php',
'PhabricatorRepositoryDAO' => 'applications/repository/storage/PhabricatorRepositoryDAO.php',
'PhabricatorRepositoryDiscoveryEngine' => 'applications/repository/engine/PhabricatorRepositoryDiscoveryEngine.php',
'PhabricatorRepositoryEditor' => 'applications/repository/editor/PhabricatorRepositoryEditor.php',
@@ -2416,7 +2414,6 @@
'PhabricatorRepositoryGitCommitMessageParserWorker' => 'applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php',
'PhabricatorRepositoryGraphCache' => 'applications/repository/graphcache/PhabricatorRepositoryGraphCache.php',
'PhabricatorRepositoryGraphStream' => 'applications/repository/daemon/PhabricatorRepositoryGraphStream.php',
- 'PhabricatorRepositoryListController' => 'applications/repository/controller/PhabricatorRepositoryListController.php',
'PhabricatorRepositoryManagementCacheWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php',
'PhabricatorRepositoryManagementDiscoverWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php',
'PhabricatorRepositoryManagementEditWorkflow' => 'applications/repository/management/PhabricatorRepositoryManagementEditWorkflow.php',
@@ -5824,7 +5821,6 @@
'PhabricatorRemarkupFigletBlockInterpreter' => 'PhutilRemarkupBlockInterpreter',
'PhabricatorRemarkupGraphvizBlockInterpreter' => 'PhutilRemarkupBlockInterpreter',
'PhabricatorRemarkupUIExample' => 'PhabricatorUIExample',
- 'PhabricatorRepositoriesApplication' => 'PhabricatorApplication',
'PhabricatorRepositoriesSetupCheck' => 'PhabricatorSetupCheck',
'PhabricatorRepository' => array(
'PhabricatorRepositoryDAO',
@@ -5868,14 +5864,12 @@
'PhabricatorRepositoryCommitParserWorker' => 'PhabricatorWorker',
'PhabricatorRepositoryCommitSearchIndexer' => 'PhabricatorSearchDocumentIndexer',
'PhabricatorRepositoryConfigOptions' => 'PhabricatorApplicationConfigOptions',
- 'PhabricatorRepositoryController' => 'PhabricatorController',
'PhabricatorRepositoryDAO' => 'PhabricatorLiskDAO',
'PhabricatorRepositoryDiscoveryEngine' => 'PhabricatorRepositoryEngine',
'PhabricatorRepositoryEditor' => 'PhabricatorApplicationTransactionEditor',
'PhabricatorRepositoryGitCommitChangeParserWorker' => 'PhabricatorRepositoryCommitChangeParserWorker',
'PhabricatorRepositoryGitCommitMessageParserWorker' => 'PhabricatorRepositoryCommitMessageParserWorker',
'PhabricatorRepositoryGraphStream' => 'Phobject',
- 'PhabricatorRepositoryListController' => 'PhabricatorRepositoryController',
'PhabricatorRepositoryManagementCacheWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
'PhabricatorRepositoryManagementDiscoverWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
'PhabricatorRepositoryManagementEditWorkflow' => 'PhabricatorRepositoryManagementWorkflow',
diff --git a/src/applications/repository/application/PhabricatorRepositoriesApplication.php b/src/applications/repository/application/PhabricatorRepositoriesApplication.php
deleted file mode 100644
--- a/src/applications/repository/application/PhabricatorRepositoriesApplication.php
+++ /dev/null
@@ -1,37 +0,0 @@
-<?php
-
-final class PhabricatorRepositoriesApplication extends PhabricatorApplication {
-
- public function getBaseURI() {
- return '/repository/';
- }
-
- public function getFontIcon() {
- return 'fa-hdd-o';
- }
-
- public function getName() {
- return pht('Repositories');
- }
-
- public function getShortDescription() {
- return pht('(Deprecated)');
- }
-
- public function getTitleGlyph() {
- return 'rX';
- }
-
- public function getApplicationGroup() {
- return self::GROUP_ADMIN;
- }
-
- public function getRoutes() {
- return array(
- '/repository/' => array(
- '' => 'PhabricatorRepositoryListController',
- ),
- );
- }
-
-}
diff --git a/src/applications/repository/controller/PhabricatorRepositoryController.php b/src/applications/repository/controller/PhabricatorRepositoryController.php
deleted file mode 100644
--- a/src/applications/repository/controller/PhabricatorRepositoryController.php
+++ /dev/null
@@ -1,15 +0,0 @@
-<?php
-
-abstract class PhabricatorRepositoryController extends PhabricatorController {
-
- public function shouldRequireAdmin() {
- // Most of these controllers are admin-only.
- return true;
- }
-
- protected function buildApplicationCrumbs() {
- $crumbs = parent::buildApplicationCrumbs();
- return $crumbs;
- }
-
-}
diff --git a/src/applications/repository/controller/PhabricatorRepositoryListController.php b/src/applications/repository/controller/PhabricatorRepositoryListController.php
deleted file mode 100644
--- a/src/applications/repository/controller/PhabricatorRepositoryListController.php
+++ /dev/null
@@ -1,101 +0,0 @@
-<?php
-
-final class PhabricatorRepositoryListController
- extends PhabricatorRepositoryController {
-
- public function processRequest() {
-
- $request = $this->getRequest();
- $user = $request->getUser();
- $is_admin = $user->getIsAdmin();
-
- $repos = id(new PhabricatorRepositoryQuery())
- ->setViewer($user)
- ->execute();
- $repos = msort($repos, 'getName');
-
- $rows = array();
- foreach ($repos as $repo) {
-
- if ($repo->isTracked()) {
- $diffusion_link = phutil_tag(
- 'a',
- array(
- 'href' => '/diffusion/'.$repo->getCallsign().'/',
- ),
- pht('View in Diffusion'));
- } else {
- $diffusion_link = phutil_tag('em', array(), pht('Not Tracked'));
- }
-
- $rows[] = array(
- $repo->getCallsign(),
- $repo->getName(),
- PhabricatorRepositoryType::getNameForRepositoryType(
- $repo->getVersionControlSystem()),
- $diffusion_link,
- phutil_tag(
- 'a',
- array(
- 'class' => 'button small grey',
- 'href' => '/diffusion/'.$repo->getCallsign().'/edit/',
- ),
- pht('Edit')),
- );
- }
-
- $table = new AphrontTableView($rows);
- $table->setNoDataString(pht('No Repositories'));
- $table->setHeaders(
- array(
- pht('Callsign'),
- pht('Repository'),
- pht('Type'),
- pht('Diffusion'),
- '',
- ));
- $table->setColumnClasses(
- array(
- null,
- 'wide',
- null,
- null,
- 'action',
- ));
-
- $table->setColumnVisibility(
- array(
- true,
- true,
- true,
- true,
- $is_admin,
- ));
-
- $panel = new PHUIObjectBoxView();
- $header = new PHUIHeaderView();
- $header->setHeader(pht('Repositories'));
- if ($is_admin) {
- $button = id(new PHUIButtonView())
- ->setTag('a')
- ->setText(pht('Create New Repository'))
- ->setHref('/diffusion/new/');
- $header->addActionLink($button);
- }
- $panel->setHeader($header);
- $panel->appendChild($table);
-
- $crumbs = $this->buildApplicationCrumbs();
- $crumbs->addTextCrumb(pht('Repository List'));
-
- return $this->buildApplicationPage(
- array(
- $crumbs,
- $panel,
- ),
- array(
- 'title' => pht('Repository List'),
- ));
- }
-
-}

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 8:01 PM (3 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6276261
Default Alt Text
D12734.diff (8 KB)

Event Timeline