Page MenuHomePhabricator
Differential D12734

Remove the repositories application
ClosedPublic
Actions

Authored by joshuaspence on May 6 2015, 12:47 PM.
Tags
None
Referenced Files
F15450607: D12734.id31601.diff
Fri, Mar 28, 4:39 PM
F15414383: D12734.id30597.diff
Thu, Mar 20, 12:22 AM
F15392589: D12734.diff
Sat, Mar 15, 4:11 PM
F15392538: D12734.id31382.diff
Sat, Mar 15, 3:49 PM
F15392227: D12734.id31601.diff
Sat, Mar 15, 1:56 PM
F15390810: D12734.id30597.diff
Sat, Mar 15, 6:46 AM
F15390488: D12734.id.diff
Sat, Mar 15, 6:15 AM
F15389847: D12734.id30597.diff
Sat, Mar 15, 5:42 AM
View All Files
Subscribers
epriestley
Tokens
"Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7603: Remove the deprecated "Repositories" application
Commits
Restricted Diffusion Commit
rPc4bcfc85f160: Remove the repositories application
Summary

Fixes T7603. This application is no longer used.

Test Plan

Went to /repository/ and got a 404.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30597.May 6 2015, 12:47 PM
joshuaspence retitled this revision from to [Draft] Remove the repositories application.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a task: T7603: Remove the deprecated "Repositories" application.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2015, 12:47 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.May 17 2015, 2:53 PM
epriestley added a reviewer: epriestley.

This (or some substantially equivalent future patch) is desirable when dependencies are resolved.

This revision is now accepted and ready to land.May 17 2015, 2:53 PM
joshuaspence added a comment.May 25 2015, 9:30 PM

Just confirming... I think this is basically safe to land now?

joshuaspence updated this revision to Diff 31382.May 25 2015, 9:33 PM
joshuaspence edited edge metadata.

Rebase

Herald added a subscriber: Korvin. · View Herald TranscriptMay 25 2015, 9:33 PM
joshuaspence retitled this revision from [Draft] Remove the repositories application to Remove the repositories application.May 25 2015, 9:33 PM
joshuaspence updated this object.
joshuaspence removed a subscriber: Korvin.
joshuaspence edited the test plan for this revision. (Show Details)May 26 2015, 11:58 AM
joshuaspence added a comment.Jun 1 2015, 5:36 AM

I'm going to land this now... the Repositories application doesn't serve a purpose any longer.

Closed by commit rPc4bcfc85f160: Remove the repositories application (authored by joshuaspence, committed by joshuaspence). · Explain WhyJun 1 2015, 5:40 AM
This revision was automatically updated to reflect the committed changes.
epriestley awarded a token.Jun 1 2015, 1:47 PM

Revision Contents
Changeset List

Diff 31601

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/repository/application/PhabricatorRepositoriesApplication.php

Loading...
View Options

src/applications/repository/controller/PhabricatorRepositoryController.php

Loading...
View Options

src/applications/repository/controller/PhabricatorRepositoryListController.php

Loading...
Phabricator · Built by Phacility