Page MenuHomePhabricator
Files F13177822

D18963.diff
No OneTemporary
Actions

D18963.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => '15191c65',
- 'core.pkg.css' => '075f9867',
+ 'core.pkg.css' => '51debec3',
'core.pkg.js' => '4c79d74f',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '45951e9e',
@@ -176,7 +176,7 @@
'rsrc/css/phui/phui-spacing.css' => '042804d6',
'rsrc/css/phui/phui-status.css' => 'd5263e49',
'rsrc/css/phui/phui-tag-view.css' => 'b4719c50',
- 'rsrc/css/phui/phui-timeline-view.css' => 'e2ef62b1',
+ 'rsrc/css/phui/phui-timeline-view.css' => '6ddf8126',
'rsrc/css/phui/phui-two-column-view.css' => '44ec4951',
'rsrc/css/phui/workboards/phui-workboard-color.css' => '783cdff5',
'rsrc/css/phui/workboards/phui-workboard.css' => '3bc85455',
@@ -873,7 +873,7 @@
'phui-status-list-view-css' => 'd5263e49',
'phui-tag-view-css' => 'b4719c50',
'phui-theme-css' => '9f261c6b',
- 'phui-timeline-view-css' => 'e2ef62b1',
+ 'phui-timeline-view-css' => '6ddf8126',
'phui-two-column-view-css' => '44ec4951',
'phui-workboard-color-css' => '783cdff5',
'phui-workboard-view-css' => '3bc85455',
diff --git a/src/view/phui/PHUITimelineEventView.php b/src/view/phui/PHUITimelineEventView.php
--- a/src/view/phui/PHUITimelineEventView.php
+++ b/src/view/phui/PHUITimelineEventView.php
@@ -301,18 +301,14 @@
$menu = null;
$items = array();
- $has_menu = false;
if (!$this->getIsPreview() && !$this->getHideCommentOptions()) {
foreach ($this->getEventGroup() as $event) {
$items[] = $event->getMenuItems($this->anchor);
- if ($event->hasChildren()) {
- $has_menu = true;
- }
}
$items = array_mergev($items);
}
- if ($items || $has_menu) {
+ if ($items) {
$icon = id(new PHUIIconView())
->setIcon('fa-caret-down');
$aural = javelin_tag(
@@ -351,6 +347,8 @@
));
$has_menu = true;
+ } else {
+ $has_menu = false;
}
// Render "extra" information (timestamp, etc).
diff --git a/webroot/rsrc/css/phui/phui-timeline-view.css b/webroot/rsrc/css/phui/phui-timeline-view.css
--- a/webroot/rsrc/css/phui/phui-timeline-view.css
+++ b/webroot/rsrc/css/phui/phui-timeline-view.css
@@ -390,10 +390,6 @@
outline: none;
}
-.phui-timeline-menu .phui-icon-view {
- color: {$lightgreytext};
-}
-
a.phui-timeline-menu .phui-icon-view {
color: {$bluetext};
}

File Metadata

Mime Type
text/plain
Expires
Thu, May 9, 7:58 PM (3 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6276196
Default Alt Text
D18963.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility