D8510.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D8510.diff
View Options

	diff --git a/src/applications/differential/customfield/DifferentialCustomField.php b/src/applications/differential/customfield/DifferentialCustomField.php
	--- a/src/applications/differential/customfield/DifferentialCustomField.php
	+++ b/src/applications/differential/customfield/DifferentialCustomField.php
	@@ -51,11 +51,15 @@
	return array();
	}

	- protected function parseObjectList($value, array $types) {
	+ protected function parseObjectList(
	+ $value,
	+ array $types,
	+ $allow_partial = false) {
	return id(new PhabricatorObjectListQuery())
	->setViewer($this->getViewer())
	->setAllowedTypes($types)
	->setObjectList($value)
	+ ->setAllowPartialResults($allow_partial)
	->execute();
	}

	diff --git a/src/applications/differential/customfield/DifferentialReviewedByField.php b/src/applications/differential/customfield/DifferentialReviewedByField.php
	--- a/src/applications/differential/customfield/DifferentialReviewedByField.php
	+++ b/src/applications/differential/customfield/DifferentialReviewedByField.php
	@@ -51,6 +51,16 @@
	return true;
	}

	+ public function parseValueFromCommitMessage($value) {
	+ return $this->parseObjectList(
	+ $value,
	+ array(
	+ PhabricatorPeoplePHIDTypeUser::TYPECONST,
	+ PhabricatorProjectPHIDTypeProject::TYPECONST,
	+ ),
	+ $allow_partial = true);
	+ }
	+
	public function getRequiredHandlePHIDsForCommitMessage() {
	return $this->getValue();
	}